From: Oguz Bektas <o.bektas@proxmox.com>
To: Dylan Whyte <d.whyte@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers
Date: Wed, 1 Dec 2021 16:11:23 +0100 [thread overview]
Message-ID: <YaeQm5u9bMuKXi1w@gaia> (raw)
In-Reply-To: <c7296592-029b-3ec4-c482-aa26d1e5dacf@proxmox.com>
On Wed, Dec 01, 2021 at 03:54:12PM +0100, Dylan Whyte wrote:
> Hi,
>
> I just tested/played with this a bit and couldn't find any issues within the
> container, with the option enabled.
>
> However, you need to add a corresponding mount option in the GUI, as
> otherwise, the "Edit: Mount Point" window breaks due to it not recognizing
> the option, and no changes can be made as a result.
oops yeah, thanks for pointing out! will send a manager patch :)
>
> Tested-by: Dylan Whyte <d.whyte@proxmox.com>
>
> On 11/29/21 1:38 PM, Oguz Bektas wrote:
> > requested in community forum [0]
> >
> > root@CT1022:/# mount | grep lazy
> > /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on / type ext4 (rw,relatime,lazytime)
> > /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime)
> >
> > [0]: https://forum.proxmox.com/threads/100454/
> >
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> > src/PVE/LXC/Config.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> > index 1e28a88..6c2acd6 100644
> > --- a/src/PVE/LXC/Config.pm
> > +++ b/src/PVE/LXC/Config.pm
> > @@ -281,7 +281,7 @@ sub __snapshot_rollback_get_unused {
> > cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
> > -my $valid_mount_option_re = qr/(noatime|nodev|nosuid|noexec)/;
> > +my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
> > sub is_valid_mount_option {
> > my ($option) = @_;
prev parent reply other threads:[~2021-12-01 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 12:38 Oguz Bektas
2021-12-01 14:54 ` Dylan Whyte
2021-12-01 15:11 ` Oguz Bektas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaeQm5u9bMuKXi1w@gaia \
--to=o.bektas@proxmox.com \
--cc=d.whyte@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox