public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] set https_proxy to http_proxy for querying url metadata
Date: Thu, 25 Nov 2021 15:14:23 +0100	[thread overview]
Message-ID: <YZ+aP5gsFh0ZeeX6@gaia> (raw)
In-Reply-To: <de8cbf5b-b868-9171-e5f0-2065bb681dba@proxmox.com>

On Thu, Nov 25, 2021 at 03:07:58PM +0100, Thomas Lamprecht wrote:
> On 25.11.21 14:49, Oguz Bektas wrote:
> > On Thu, Nov 25, 2021 at 02:34:54PM +0100, Dominik Csapak wrote:
> >> this sadly does not work, comment inline
> >>
> > ah thanks... i guess i forgot to restart the daemon when testing. sent a
> > v2 now!
> > 
> 
> So the squid access logs from the commit message are bogus?
> 

no... the original one i had was with two lines instead of the array so
it worked properly. i just forgot to restart pveproxy after changing and didnt notice.




      reply	other threads:[~2021-11-25 14:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 14:13 [pve-devel] [PATCH manager storage 0/2] fix #3716: allow https proxy for URL download Oguz Bektas
2021-11-09 14:13 ` [pve-devel] [PATCH storage 1/2] download-url: reuse http_proxy from datacenter.cfg for https Oguz Bektas
2021-11-25 13:34   ` Dominik Csapak
2021-11-25 14:06     ` Thomas Lamprecht
2021-11-25 14:23       ` Dominik Csapak
2021-11-09 14:13 ` [pve-devel] [PATCH manager 2/2] set https_proxy to http_proxy for querying url metadata Oguz Bektas
2021-11-25 13:34   ` Dominik Csapak
2021-11-25 13:49     ` Oguz Bektas
2021-11-25 14:07       ` Thomas Lamprecht
2021-11-25 14:14         ` Oguz Bektas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ+aP5gsFh0ZeeX6@gaia \
    --to=o.bektas@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal