[pve-devel] [PATCH manager] lxc: add 'unmanaged' checkbox in wizard

[pve-devel] [PATCH manager] lxc: add 'unmanaged' checkbox in wizard

[Oguz Bektas]

to allow creating containers with 'unmanaged' ostype easily in GUI.
that way we can use other unsupported templates in the GUI as well.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 www/manager6/lxc/CreateWizard.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index aead515f..1befe928 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -72,6 +72,13 @@ Ext.define('PVE.lxc.CreateWizard', {
 		    },
 		    fieldLabel: gettext('Nesting'),
 		},
+		{
+		    xtype: 'proxmoxcheckbox',
+		    name: 'ostype',
+		    inputValue: 'unmanaged',
+		    value: false,
+		    fieldLabel: gettext('Unmanaged container'),
+		},
 	    ],
 	    column2: [
 		{
-- 
2.30.2

Re: [pve-devel] [PATCH manager] lxc: add 'unmanaged' checkbox in wizard

[Thomas Lamprecht]

On 04.11.21 14:19, Oguz Bektas wrote:
> to allow creating containers with 'unmanaged' ostype easily in GUI.
> that way we can use other unsupported templates in the GUI as well.

it's rather an advanced option, but I'm not even sure I want it there,
unmanaged CTs are def. not the norm. Is there any user demand for this?

Re: [pve-devel] [PATCH manager] lxc: add 'unmanaged' checkbox in wizard

[Oguz Bektas]

On Thu, Nov 04, 2021 at 02:58:25PM +0100, Thomas Lamprecht wrote:
> On 04.11.21 14:19, Oguz Bektas wrote:
> > to allow creating containers with 'unmanaged' ostype easily in GUI.
> > that way we can use other unsupported templates in the GUI as well.
> 
> it's rather an advanced option, but I'm not even sure I want it there,
> unmanaged CTs are def. not the norm. Is there any user demand for this?

no feature request or the like.
but it adds more flexibility to the GUI, e.g. you wouldn't have to
create your container from the command line when using a custom
(unsupported) distribution template.

i thought about hiding it behind "Advanced" as well but it seems that
doesn't work at all on the container wizard?

Re: [pve-devel] [PATCH manager] lxc: add 'unmanaged' checkbox in wizard

[Thomas Lamprecht]

On 04.11.21 15:01, Oguz Bektas wrote:
> On Thu, Nov 04, 2021 at 02:58:25PM +0100, Thomas Lamprecht wrote:
>> On 04.11.21 14:19, Oguz Bektas wrote:
>>> to allow creating containers with 'unmanaged' ostype easily in GUI.
>>> that way we can use other unsupported templates in the GUI as well.
>>
>> it's rather an advanced option, but I'm not even sure I want it there,
>> unmanaged CTs are def. not the norm. Is there any user demand for this?
> 
> no feature request or the like.
> but it adds more flexibility to the GUI, e.g. you wouldn't have to
> create your container from the command line when using a custom
> (unsupported) distribution template.

1. it crowds the interface more for an very rare use case that nobody expressed
   their desire  for yet, that alone can often be an anti-feature.

2. more important, it may easily get ticked by unknowing users, as its probably
   not exactly clear what it actually does to a big chunk of users (its not a
   standard action) - especially as one then can still configure the network,
   dns and other things but they simply won't have any effect anymore, that's
   not good UX..

Further, note that we already automatically fall-back to `unmanaged` and also
accept it as unmanaged if denoted as such in the `/etc/os-release` file, that's
enough flexibility for an odd use-case, any user can prepare their archives to
match that, else they can always use the CLI or API.

> 
> i thought about hiding it behind "Advanced" as well but it seems that
> doesn't work at all on the container wizard?

1. If we'd really add it (and I'm not agreeing on that currently), it'd belong
   into the `Template` panel, there the appliance selection (for which this is
   relevant) happens.

2. The advanced mode works in general just fine in the CT wizard, e.g., see the
   Disks and CPU tabs. The advanced mechanism is a shared feature between the
   EditWindow (control the checkbox) and InputPanel (holds the advanced items)
   components, maybe you did not added it in an InputPanel or used the wrong
   config properties, hard to tell without seeing code ;-)