From: Oguz Bektas <o.bektas@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix removing cpulimit on running vm
Date: Thu, 21 Oct 2021 16:51:44 +0200 [thread overview]
Message-ID: <YXF+gNNcV6oqriDt@gaia> (raw)
In-Reply-To: <eb987813-d31a-7b9e-2746-4cf92b3b3428@proxmox.com>
On Thu, Oct 21, 2021 at 04:21:12PM +0200, Dominik Csapak wrote:
> On 10/21/21 13:43, Oguz Bektas wrote:
> > On Thu, Oct 21, 2021 at 12:51:43PM +0200, Dominik Csapak wrote:
> > > On 10/21/21 11:53, Oguz Bektas wrote:
> > > > hi,
> > > >
> > > > works for cgroupv2 but with 'systemd.unified_cgroup_hierarchy=0' in
> > > > cmdline it errors:
> > > >
> > > >
> > > > ====
> > > > update VM 101: -delete cpulimit
> > > > 400 Parameter verification failed.
> > > > cpulimit: hotplug problem - closing file
> > > > '/sys/fs/cgroup/cpu/qemu.slice/101.scope//cpu.cfs_period_us' failed -
> > > > Invalid argument
> > > > ====
> > > >
> > > >
> > >
> > > hm... does this work for running containers? since we use the
> > > exact same code there for cpulimit...
> >
> > apparently doesn't work there either
> >
>
> ok i guess then we should fix it in pve-common and keep this patch as is?
>
yep i've sent patch for pve-common now, with that applied your fix works
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
Reviewed-by: Oguz Bektas <o.bektas@proxmox.com>
next prev parent reply other threads:[~2021-10-21 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:20 Dominik Csapak
2021-10-21 9:53 ` Oguz Bektas
2021-10-21 10:51 ` Dominik Csapak
2021-10-21 11:43 ` Oguz Bektas
2021-10-21 14:21 ` Dominik Csapak
2021-10-21 14:51 ` Oguz Bektas [this message]
2021-10-22 10:04 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXF+gNNcV6oqriDt@gaia \
--to=o.bektas@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox