From: Maximilian Hill <mhill@inett.de>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix #3329: turn on cache=writeback for efidisks on rbd
Date: Wed, 16 Jun 2021 15:25:07 +0200 [thread overview]
Message-ID: <YMn7szm3nmk+OzV9@inett.de> (raw)
In-Reply-To: <20210616130933.30336-1-d.csapak@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
Hello,
On Wed, Jun 16, 2021 at 03:09:33PM +0200, Dominik Csapak wrote:
> on slower ceph clusters, the write pattern of the ovmf booting process
> slows down the boot of the vm, so we turn on caching by default
>
> + my $cache = "";
> + if ($path =~ m/^rbd:/) {
> + $cache = ',cache=writeback';
does this work, evven if the rbd storage is not called "rbd"?
> + }
> +
> push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code";
> - push @$cmd, '-drive', "if=pflash,unit=1,format=$format,id=drive-efidisk0$size_str,file=$path";
> + push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=$path";
> }
>
> # load q35 config
> --
> 2.20.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-16 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 13:09 Dominik Csapak
2021-06-16 13:25 ` Maximilian Hill [this message]
2021-06-16 13:34 ` Thomas Lamprecht
2021-06-16 13:47 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMn7szm3nmk+OzV9@inett.de \
--to=mhill@inett.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox