[pve-devel] [PATCH pve-storage v1 1/2] fix #4929: iscsi: add hidden option to hide storage from UI

[pve-devel] [PATCH pve-storage v1 1/2] fix #4929: iscsi: add hidden option to hide storage from UI

[nansen.su]

  This patch adds a 'hidden' boolean option to the iSCSI storage plugin.
  When enabled, it allows hiding the storage from the resource tree in
  the web interface while keeping it functional for actual storage operations.

  This is part 1 of 2 patches that together implement hidden storage
  support for iSCSI. The corresponding UI changes are submitted
  separately to pve-manager.

  Related: [PATCH pve-manager v1 2/2] ui: add hidden storage support for iSCSI

  Signed-off-by: Nansen Su

---
 src/PVE/Storage/ISCSIPlugin.pm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
index 7691ec6..c6ccc07 100644
--- a/src/PVE/Storage/ISCSIPlugin.pm
+++ b/src/PVE/Storage/ISCSIPlugin.pm
@@ -351,6 +351,12 @@ sub properties {
             type => 'string',
             format => 'pve-storage-portal-dns',
         },
+        hidden => {
+            description => "Hide this storage from the resource tree.",
+            type => 'boolean',
+            optional => 1,
+            default => 0,
+        },
     };
 }
 
@@ -362,6 +368,7 @@ sub options {
         disable => { optional => 1 },
         content => { optional => 1 },
         bwlimit => { optional => 1 },
+        hidden => { optional => 1 },
     };
 }
 
-- 
2.50.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-storage v1 1/2] fix #4929: iscsi: add hidden option to hide storage from UI

[Thomas Lamprecht]

Am 30.07.25 um 07:41 schrieb nansen.su:
>   This patch adds a 'hidden' boolean option to the iSCSI storage plugin.
>   When enabled, it allows hiding the storage from the resource tree in
>   the web interface while keeping it functional for actual storage operations.

And why should one want that? Can you provide some rationale?




_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-storage v1 1/2] fix #4929: iscsi: add hidden option to hide storage from UI

[Fabian Grünbichler]

On July 30, 2025 11:48 am, Thomas Lamprecht wrote:
> Am 30.07.25 um 07:41 schrieb nansen.su:
>>   This patch adds a 'hidden' boolean option to the iSCSI storage plugin.
>>   When enabled, it allows hiding the storage from the resource tree in
>>   the web interface while keeping it functional for actual storage operations.
> 
> And why should one want that? Can you provide some rationale?

I think the rationale is "hidden" in the bug report - for some setups
you might have N iSCSI storages backing a single shared LVM storage, and
those iSCSI storages pollute the UI view since only the LVM storage on
top is actually relevant for the user/admin in daily operations..


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-storage v1 1/2] fix #4929: iscsi: add hidden option to hide storage from UI

[蘇國瑋]

The rationale is for iSCSI multipath configurations. Many users migrating to 
Proxmox have multiple iSCSI storage entries pointing to the same underlying 
storage for redundancy.
These create clutter in the sidebar and don't show useful capacity 
information since they represent the same storage.

The 'hidden' option allows keeping multipath functionality intact while 
hiding redundant entries from the web interface, providing a cleaner 
management experience for enterprise iSCSI multipath setups.


From: Fabian Grünbichler <f.gruenbichler@proxmox.com>
To: "nansen.su" <nansen.su@sianit.com>, Proxmox VE development discussion 
<pve-devel@lists.proxmox.com>
Date: Wed, 30 Jul 2025 12:10:29 +0200
Subject: Re: [pve-devel] [PATCH pve-storage v1 1/2] fix #4929: iscsi: add 
hidden option to hide storage from UI


On July 30, 2025 11:48 am, Thomas Lamprecht wrote:
> Am 30.07.25 um 07:41 schrieb nansen.su:
>>   This patch adds a 'hidden' boolean option to the iSCSI storage plugin.
>>   When enabled, it allows hiding the storage from the resource tree in
>>   the web interface while keeping it functional for actual storage 
operations.
>
> And why should one want that? Can you provide some rationale?

I think the rationale is "hidden" in the bug report - for some setups
you might have N iSCSI storages backing a single shared LVM storage, and
those iSCSI storages pollute the UI view since only the LVM storage on
top is actually relevant for the user/admin in daily operations..
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel