From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Cc: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-common] fix #4299: network : disable_ipv6: fix path checking
Date: Thu, 20 Oct 2022 16:18:06 +0000 [thread overview]
Message-ID: <PAZP264MB24942D33438AE765111431F1A12A9@PAZP264MB2494.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20221020100557.pncxpsemrinqwghf@casey.proxmox.com>
I'm really unable to reproduce this.
User is able to reproduce it 100%, depending on the brigde where the vm is started.
(some bridge with sdn generated for example).
I don't have asked to user to reboot.
ifupdown2 seem to thrown warning too, so I don't known if it's a special sysctl triggering this, or a kernel bug, or something else.
________________________________
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Sent: Thursday, October 20, 2022 12:05 PM
To: Alexandre Derumier <aderumier@odiso.com>
Cc: pve-devel@lists.proxmox.com <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-common] fix #4299: network : disable_ipv6: fix path checking
On Thu, Oct 20, 2022 at 12:24:29AM +0200, Alexandre Derumier wrote:
> It's possible to have a
> /proc/sys/net/ipv6/ directory
>
> but no
> /proc/sys/net/ipv6/conf/$iface/disable_ipv6
Do we know why this happens? That doesn't seem right to me, unless
some kind of race somewhere with the interface creation?
Or is there a legitimate kernel option that causes this?
>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> src/PVE/Network.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm
> index c468e40..9d726cd 100644
> --- a/src/PVE/Network.pm
> +++ b/src/PVE/Network.pm
> @@ -210,8 +210,8 @@ my $cond_create_bridge = sub {
>
> sub disable_ipv6 {
> my ($iface) = @_;
> - return if !-d '/proc/sys/net/ipv6'; # ipv6 might be completely disabled
> my $file = "/proc/sys/net/ipv6/conf/$iface/disable_ipv6";
> + return if !-e $file; # ipv6 might be completely disabled
> open(my $fh, '>', $file) or die "failed to open $file for writing: $!\n";
> print {$fh} "1\n" or die "failed to disable link-local ipv6 for $iface\n";
> close($fh);
> --
> 2.30.2
next prev parent reply other threads:[~2022-10-20 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 22:24 Alexandre Derumier
2022-10-20 10:05 ` Wolfgang Bumiller
2022-10-20 16:18 ` DERUMIER, Alexandre [this message]
[not found] ` <mailman.64.1666287516.489.pve-devel@lists.proxmox.com>
2022-10-21 4:55 ` DERUMIER, Alexandre
2022-10-21 8:16 ` Wolfgang Bumiller
2023-01-16 9:45 ` [pve-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAZP264MB24942D33438AE765111431F1A12A9@PAZP264MB2494.FRAP264.PROD.OUTLOOK.COM \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox