From: "Jakob Klocker" <j.klocker@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: applied: [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA
Date: Thu, 19 Nov 2026 07:36:52 +0100 [thread overview]
Message-ID: <DMYZA7ESIX91.1OWCX5QOM4TCJ@proxmox.com> (raw)
In-Reply-To: <179501161066.1321919.3320586608164988877.b4-ty@b4>
On Wed Nov 18, 2026 at 3:22 PM CET, Thomas Lamprecht wrote:
>> [snip]
>
> Applied, thanks!
>
> I adapted a few things while/on applying, mainly:
>
> - ui: the agent editor now loads a value of 'yes' or 'on' for the new
> option as checked. Before, it showed such a value as unchecked, so
> saving any other agent setting dropped the option.
> - qemu-server: reworded the FIXME about enabling the option by default
> and dropped its version number, like the other major version markers.
> - guest-common, qemu-server: wrapped two calls with their arguments as
> one block, as proxmox-perltidy keeps that form.
>
> On top, I added a qemu-server commit with tests for which setting
> decides the sync after a rollback with RAM and for
> should_sync_time_on_resume():
>
> tests: cover the guest time sync decision, also for snapshot rollback
> https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=7cf9da59d92f31c7eb00b97dcb17cfa0d7e0c2b6
>
> Two things are still missing and could be nice as follow-ups:
>
> - the agent section of the admin guide (qm.adoc) does not document the
> new option yet.
> - the Yew agent editor in proxmox-yew-comp, as used by the mobile UI and
> PDM, drops the option on save, as pve-api-types does not know it yet.
> That needs a regeneration of pve-api-types and a checkbox there.
>
Thanks for the improvements. I'll add the follow-ups to my
backlog.
next prev parent reply other threads:[~2026-11-19 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:39 [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA Jakob Klocker
2026-11-17 12:39 ` [PATCH pve-guest-common v7 1/3] AbstractConfig: allow passing options to snapshot_rollback Jakob Klocker
2026-11-17 12:39 ` [PATCH pve-manager v7 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option Jakob Klocker
2026-11-17 12:39 ` [PATCH qemu-server v7 3/3] fix #5032: agent: sync guest time via QGA when the clock falls behind Jakob Klocker
2026-11-18 14:22 ` applied: [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA Thomas Lamprecht
2026-11-19 6:36 ` Jakob Klocker [this message]
2026-11-19 8:52 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMYZA7ESIX91.1OWCX5QOM4TCJ@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox