public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>,
	"Thomas Lamprecht" <t.lamprecht@proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>,
	<pve-devel@lists.proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding
Date: Wed, 18 Nov 2026 12:17:44 +0100	[thread overview]
Message-ID: <DMYAMPKOIV23.2FXDD6QDDI3UN@proxmox.com> (raw)
In-Reply-To: <28a30f3c-f9bb-4d24-8150-a8d35ca81f30@proxmox.com>

Thank you for the discussion!

On Wed Nov 18, 2026 at 11:14 AM CET, Fiona Ebner wrote:
> Am 18.11.26 um 9:32 AM schrieb Thomas Lamprecht:
>> Am 18.11.26 um 08:48 schrieb Dominik Csapak:
>>> On 11/17/26 6:20 PM, Thomas Lamprecht wrote:
>>>> Am 11.11.26 um 16:22 schrieb Elias Huhsovitz:
>>>>>       "pve-qemu-server-pci"
>>>>>   ]
>>>>
>>>> applies to yours and Dominiks [pci series]: I'd rather not propagate
>>>> the naming oddity of including "server" here to rust, when we finally
>>>> got a chance of dropping some legacy decisions cheaply.
>>>> I.e., lets do at least a s/server// please, server does made really
>>>> sense in how "qemu-server" gets used nowadays.
>>>
>>> sure of course, i just started with something and didn't get feedback
>>> on the naming (until now) so that's fine by me
>>>
>>> (i feared 'pve-qemu-rs' is too close to 'pve-qemu-kvm' or 'pve-qemu',
>>> but if it's fine for you i'll change it)
>> 
>> FWIW, pve-vm is fine too for me. But here I'd appreciate some input
>> from the people working most in this subsystems.
>> 
>>>> And another thing that would be easy to do now: put these into the
>>>> qemu-server repo directly and generate a perlmod backed library
>>>> there. Each change, addition would then avoid going through an
>>>> extra repo and packaging, and qemu management is a big, important
>>>> and well enough scoped use case to justify a dedicated lib here (which
>>>> I'd not do for all repos).
>>>
>>> sure, started fresh to not run into merge conflicts and basically
>>> starting from a clean slate regarding build system
>>> (which made my life easier). I'll send a new version of my
>>> series integrating it into qemu-server repo
>> 
>> I'd not rush this to quickly now (just to avoid needless work), as
>> mentioned already initially, maintainers should have a say here and
>> asking them directly on such core naming is more fruitful than hoping
>> it gets noticed when seeing a series fly by on the list.
>> 
>
> I agree having it in the qemu-server repo directly would be nice.

Noted, this just leaves me with one question, I would like to have
answered before continuing with the new version:

What is the concensus on "rust vs perl" for this code?

I originally chose rust, because:
* Type system
* Better data structures
* Directly calling sched_setaffinity(2) so we don't have go use the
  taskset wrapper.
* Potential future optimizations where a low-level language might come
  in handy.
* v1/v2 was written in perl, but it quickly became very convoluted IMHO.
  (But I think I can design it in a more straightforward way this time
  around)

But I do acknowledge the downsides. Since, you are the Maintainers, I
would love to hear your opinion :)

>
> I feel like pve-qemu-rs might be fine. Rust crates for the management
> layer for pve-qemu(-kvm), so in that sense, closely related. Or
> pve-qemu-manager(-rs)? Or what is the concrete worry with the name being
> too similar?
>
> With pve-vm, the danger is that we add a second VM guest type at some
> point in the future, which is not related to QEMU. Then we might be
> tempted to put it into the same crate/workspace or have a confusing
> name, which might not be ideal. But I guess we could manage, so would
> also be fine by me.
>
> For Dominik's PCI series, the interface looks good to me. It's not too
> invasive to the current code, while also allowing to move more parts of
> config generation there in the future. Some parts like machine version
> checking/hardware config, could be better separated, as they are not
> specific to PCI.





  reply	other threads:[~2026-11-18 11:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 15:20 [RFC proxmox-perl-rs/qemu-server/qemu-server-rs v4 0/4] vCPU binding for qemu guests Elias Huhsovitz
2026-11-11 15:20 ` [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding Elias Huhsovitz
2026-11-17 16:28   ` Dominik Csapak
2026-11-19  9:16     ` Elias Huhsovitz
2026-11-19 10:06       ` Dominik Csapak
2026-11-17 17:20   ` Thomas Lamprecht
2026-11-18  7:47     ` Dominik Csapak
2026-11-18  8:32       ` Thomas Lamprecht
2026-11-18 10:14         ` Fiona Ebner
2026-11-18 11:17           ` Elias Huhsovitz [this message]
2026-11-18 11:44             ` Thomas Lamprecht
2026-11-18 13:05               ` Elias Huhsovitz
2026-11-11 15:20 ` [PATCH proxmox-perl-rs v4 2/4] pve: cpu: add binding for pve-qemu-server-cpu crate Elias Huhsovitz
2026-11-17 16:37   ` Dominik Csapak
2026-11-11 15:20 ` [PATCH qemu-server v4 3/4] helpers: return integer values for parse_number_sets Elias Huhsovitz
2026-11-17 16:39   ` Dominik Csapak
2026-11-11 15:20 ` [PATCH qemu-server v4 4/4] cpu: add cpu binding Elias Huhsovitz
2026-11-17 16:36   ` Dominik Csapak
2026-11-19  9:35     ` Elias Huhsovitz
2026-11-19 10:07       ` Dominik Csapak
2026-11-19 13:16         ` Elias Huhsovitz
2026-11-19 17:08           ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYAMPKOIV23.2FXDD6QDDI3UN@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal