public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH ha-manager v2 12/16] lrm: update the service status once per work iteration
Date: Mon, 16 Nov 2026 11:32:37 +0100	[thread overview]
Message-ID: <DMWKF2QTQZZX.1B9W76VBB195L@proxmox.com> (raw)
In-Reply-To: <20261112163113.294302-15-d.kral@proxmox.com>

On Thu Nov 12, 2026 at 5:31 PM CET, Daniel Kral wrote:

[snip]

> diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
> index 7ae239ec..a68ab008 100644
> --- a/src/PVE/HA/LRM.pm
> +++ b/src/PVE/HA/LRM.pm
> @@ -385,7 +385,7 @@ sub work {
>      my $status = $self->get_local_status();
>      my $state = $status->{state};
>
> -    $self->update_lrm_status();
> +    my $status_update_successful = $self->update_lrm_status();
>
>      my $fence_request = $self->is_fence_requested();
>
> @@ -516,7 +516,7 @@ sub work {
>
>              # if we could not get the current service status there's no point
>              # in doing anything, try again next round.
> -            return if !$self->update_lrm_status();
> +            return if !$status_update_successful;
>
>              if ($self->{shutdown_request}) {
>
> @@ -615,7 +615,7 @@ sub work {
>      } elsif ($state eq 'maintenance') {
>
>          my $startime = $haenv->get_time();
> -        return if !$self->update_lrm_status();
> +        return if !$status_update_successful;

I noticed that in the 'active' branch, this happens inside an eval,
resulting in a `return 1` from the `work()` function, whereas here it
would `return undef`. Is there a reason for this? Because just from
reading through the `work()` function and where it's used (haven't
tried this yet) it seems like this would stop the LRM entirely? On the
master this would happen if the second call of `update_lrm_status()`
failed for some reason. Here, I think the following could happen:

	# pmxcfs is temporarily unavailable, so this is undef
	my $status_update_successful = $self->update_lrm_status();

	# pmxcfs is up again within 5s (the max wait time for getting the
	# lock)

	# this works now
	get_protected_ha_agent_lock();

	...

	# in maintenance branch
	return if !$status_update_successful; # returns due to stale status

This doesn't introduce the problem, but widens then window for it, no?
I'll try to test this as well. I don't think this is very likely to
occur (considering pmxcfs has to be unwritable and then writable again
within a ~5s window), but it could also easily be avoided, unless I'm
missing something about why there's no eval in for the maintenance
block?

>
>          # wait until all active services moved away
>          my $service_count = $self->active_service_count();
> diff --git a/src/test/test-cfs-unavailable1/log.expect b/src/test/test-cfs-unavailable1/log.expect
> index a9bb10f2..4d796c50 100644
> --- a/src/test/test-cfs-unavailable1/log.expect
> +++ b/src/test/test-cfs-unavailable1/log.expect
> @@ -36,27 +36,22 @@ info    120      cmdlist: execute service vm:101 stopped
>  err     120    node1/crm: could not read manager status: cfs connection refused - not mounted?
>  err     120    node1/crm: got unexpected error - cfs connection refused - not mounted?
>  err     121    node1/lrm: updating service status from manager failed: cfs connection refused - not mounted?
> -err     121    node1/lrm: updating service status from manager failed: cfs connection refused - not mounted?
>  err     121    node1/lrm: unable to write lrm status file - cfs connection refused - not mounted?
>  err     140    node1/crm: could not read manager status: cfs connection refused - not mounted?
>  err     140    node1/crm: got unexpected error - cfs connection refused - not mounted?
>  err     141    node1/lrm: updating service status from manager failed: cfs connection refused - not mounted?

[snip]




  reply	other threads:[~2026-11-16 10:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 16:30 [PATCH-SERIES ha-manager v2 00/16] some sid parsing and LRM speedup improvements Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 01/16] resources: remove commented ipaddr resource type Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 02/16] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-11-12 22:33   ` Thomas Lamprecht
2026-11-13 15:04     ` Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 03/16] tree-wide: remove unused return values at parse_sid callsites Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 04/16] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 05/16] make parse_sid always return an array Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 06/16] config: use early returns in parse_sid Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 07/16] config: introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 08/16] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 09/16] lrm: rename update_lrm_status to flush_lrm_status Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 10/16] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 11/16] lrm: document and initialize LRM instance properties Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 12/16] lrm: update the service status once per work iteration Daniel Kral
2026-11-16 10:32   ` Michael Köppl [this message]
2026-11-16 12:40     ` Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 13/16] lrm: read service config " Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 14/16] lrm: compute valid service uids hash set " Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 15/16] lrm: resource_command_finished: avoid writing stale LRM results Daniel Kral
2026-11-12 16:31 ` [PATCH ha-manager v2 16/16] lrm: prune stale LRM results once per work iteration Daniel Kral
2026-11-17 18:58 ` [PATCH-SERIES ha-manager v2 00/16] some sid parsing and LRM speedup improvements Michael Köppl
2026-11-18 14:41 ` superseded: " Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMWKF2QTQZZX.1B9W76VBB195L@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal