From: "Max R. Carrara" <m.carrara@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH common,qemu-server,network,manager 0/10] mark secrets in schemas and redact them from the system report
Date: Fri, 13 Nov 2026 19:14:49 +0100 [thread overview]
Message-ID: <DMUADBIDCICY.1JW38YC480HJH@proxmox.com> (raw)
In-Reply-To: <20261101213835.353604-1-t.lamprecht@proxmox.com>
On Sun Nov 1, 2026 at 10:34 PM CET, Thomas Lamprecht wrote:
> The system report only requires Sys.Audit, but contains all guest configs
> and the SDN configs verbatim. So it includes cloud-init passwords, in plain
> text for Windows guests, and the API tokens of SDN IPAM and DNS
> integrations. A report is often sent to support by someone who does not
> own these credentials, for example a hosting provider renting out VMs.
>
> This series adds a 'sensitive' flag for schema properties and uses it to
> redact the report [...]
Haven't found anything off. The only sus thing is that `git am -3`
fumbles applying patch #7; the conflict is trivial to fix.
Did some basic smoke-testing; the `pvereport` on my dev machine doesn't
look any different than before, since there are no sensitive properties
declared anywhere.
For storage, we'd have to deprecate the `sensitive-properties` key in
`plugindata()` together with `::Plugin::sensitive_properties()` at some
point, because these properties are currently not taken into account.
When slapping a new property for testing purposes into the SSHFS plugin
and marking it as sensitive like the series describes, the property does
get redacted as expected in `pvereport`. Neat.
As mentioned above, if I remove `sensitive => 1` and add it to the
`sensitive-properties` key in `plugindata()`, it obviously does not get
redacted. This is painfully obvious from the diffs, but wanted to check
this again explicitly anyway.
LGTM.
Consider:
Reviewed-by: Max R. Carrara <m.carrara@proxmox.com>
Tested-by: Max R. Carrara <m.carrara@proxmox.com>
next prev parent reply other threads:[~2026-11-13 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 21:34 [PATCH common,qemu-server,network,manager 0/10] mark secrets in schemas and redact them from the system report Thomas Lamprecht
2026-11-01 21:34 ` [PATCH common 01/10] section config: do not add isolated property lists on lookups Thomas Lamprecht
2026-11-01 21:34 ` [PATCH common 02/10] schema: allow marking properties as sensitive Thomas Lamprecht
2026-11-01 21:34 ` [PATCH common 03/10] schema: add helpers to redact sensitive values Thomas Lamprecht
2026-11-01 21:34 ` [PATCH common 04/10] section config: add redaction of sensitive values in raw configs Thomas Lamprecht
2026-11-01 21:34 ` [PATCH qemu-server 05/10] cloud-init: mark the password as sensitive Thomas Lamprecht
2026-11-01 21:34 ` [PATCH qemu-server 06/10] config: hide sensitive values of unparsable lines in warnings Thomas Lamprecht
2026-11-01 21:34 ` [PATCH network 07/10] sdn: ipam, dns: mark API tokens as sensitive Thomas Lamprecht
2026-11-01 21:34 ` [PATCH manager 08/10] report: redact sensitive values from guest, storage and SDN configs Thomas Lamprecht
2026-11-01 21:34 ` [PATCH manager 09/10] report: redact credentials in URLs, options and environment variables Thomas Lamprecht
2026-11-01 21:34 ` [PATCH manager 10/10] pvereport: man page: document which values get redacted Thomas Lamprecht
2026-11-13 18:14 ` Max R. Carrara [this message]
2026-11-16 11:00 ` applied: [PATCH common,qemu-server,network,manager 0/10] mark secrets in schemas and redact them from the system report Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMUADBIDCICY.1JW38YC480HJH@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox