Re: [PATCH ifupdown2 v2 0/2] ifupdown2 vxlan fixes

["Lukas Sichert" <l.sichert@proxmox.com>]

On 2026-11-06 18:15, Gabriel Goller <g.goller@proxmox.com> wrote:

> This series avoids unnecessary vxlan and vlan device recreation on reload
> and fixes IPv6 peer detection in the vxlan fdb. More details are in the
> commit messages.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> Wasn't sure if I should leave the old patch and make a new one
> overriding it or if I should delete it. Went for the second version, let
> me know if I should do it differently.

In my opinion removing the old patch is nicer to read, because the diff
then shows the change in behavior directly. Also, if one were to
upstream this patch, it is nicer not to have to drop two patches,
neither of which matches upstream.

Tested on two nodes with a vxlan device and a vlan device on a bridge.
Changing vxlan-remoteip (add, remove, remove all), vxlan-ttl and, on the
vlan, address and mtu was applied by ifreload without recreating the
device, and the resulting settings matched the config. Changing vxlan-id
and removing an address with address-purge no still recreated the
device. With an IPv6 vxlan (two IPv6 vxlan-remoteip entries) removing
one remote now also removes its fdb entry while the device is kept.

Therefore consider:
Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Lukas Sichert <l.sichert@proxmox.com>