Re: [PATCH proxmox-perl-rs 06/15] fix #7993: pve-rs: resource-scheduling: add weights to pve bindings

["Daniel Kral" <d.kral@proxmox.com>]

The same applies here as in the changes for proxmox_resource_scheduling,
this would need a versioned break, e.g., if users have a newer libpve-rs
but an older ha-manager, the HA Manager would fail calling these as the
function signature was changed.

Though here, we could probably add options structs at the end of the
function parameter list instead of having extra weighted_ versions,
e.g.:

#[derive(Deserialize, Debug)]
struct BruteforceOptions {
    #[serde(default = "1")]
    cpu_weight: usize,
    #[serde(default = "1")]
    mem_weight: usize,
}

#[export]
pub fn score_best_balancing_migration_candidates(
    #[try_from_ref] this: &Scheduler,
    candidates: Vec<CompactMigrationCandidate>,
    limit: usize,
    options: BruteforceOptions,
) -> Result<Vec<ScoredMigration>, Error> {}


AFAIK this shouldn't cause old pve-ha-manager versions failing to call
this as there's a default value for each parameter. Could also be a
struct with all fields being some Option<T> and then doing the default
thing in the function body itself.

Haven't tested this yet though.

On Wed Oct 21, 2026 at 10:59 AM CEST, Dominik Rusovac wrote:
> Add weights for weighted load balancing.
>
> Adjust existing resource scheduling test to explicitly use same weights
> as before.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>  .../resource_scheduling/pve_dynamic.rs        | 27 +++++++++++++++----
>  .../resource_scheduling/pve_static.rs         | 25 +++++++++++++----
>  pve-rs/test/resource_scheduling.pl            |  3 ++-
>  3 files changed, 44 insertions(+), 11 deletions(-)
>
> diff --git a/pve-rs/src/bindings/resource_scheduling/pve_dynamic.rs b/pve-rs/src/bindings/resource_scheduling/pve_dynamic.rs
> index 8e066e0..d6b6f9b 100644
> --- a/pve-rs/src/bindings/resource_scheduling/pve_dynamic.rs
> +++ b/pve-rs/src/bindings/resource_scheduling/pve_dynamic.rs
> @@ -166,10 +166,16 @@ pub mod pve_rs_resource_scheduling_dynamic {
>      ///
>      /// See [`proxmox_resource_scheduling::scheduler::Scheduler::node_imbalance`].
>      #[export]
> -    pub fn calculate_node_imbalance(#[try_from_ref] this: &Scheduler) -> f64 {
> +    pub fn calculate_node_imbalance(
> +        #[try_from_ref] this: &Scheduler,
> +        cpu_weight: usize,
> +        mem_weight: usize,
> +    ) -> f64 {
>          let usage = this.inner.lock().unwrap();
>  
> -        usage.to_scheduler::<IdentityAggregator>().node_imbalance()
> +        usage
> +            .to_scheduler::<IdentityAggregator>()
> +            .node_imbalance(cpu_weight as f64, mem_weight as f64)
>      }
>  
>      /// Method: Scores the given migration `candidates` by the best node imbalance improvement with
> @@ -181,6 +187,8 @@ pub mod pve_rs_resource_scheduling_dynamic {
>          #[try_from_ref] this: &Scheduler,
>          candidates: Vec<CompactMigrationCandidate>,
>          limit: usize,
> +        cpu_weight: usize,
> +        mem_weight: usize,
>      ) -> Result<Vec<ScoredMigration>, Error> {
>          let usage = this.inner.lock().unwrap();
>  

[ -->8- snip -8<-- ]