Re: [PATCH perl-rs v4 3/6] fabrics: openfabric: enable force_forwarding for ipv6 transit traffic

["Lukas Sichert" <l.sichert@proxmox.com>]

Thanks for the response comments inline:

On 2026-08-24 09:27, Hannes Laimer <h.laimer@proxmox.com> wrote:

> On 2026-07-27 15:55, Lukas Sichert wrote:
>>              writeln!(interface, "\tlink-type {link_type}")?;
>>          }
>>          writeln!(interface, "\tip-forward 1")?;
>> +        if cidr.is_ipv6() {
>> +            writeln!(
>> +                interface,
>> +                "\tpost-up echo 1 > /proc/sys/net/ipv6/conf/{name}/force_forwarding"
>> +            )?;
>
> this ends up on the dummy interfaces, but that never actually get
> traffic, this should be on the underlaying interfaces the fabric is
> configured on

get_interfaces_etc_network_config() calls render_dummy_interfaces() for
the dummies, and render_interface() directly for each interface listed
in the fabric node section of /etc/pve/sdn/fabrics.cfg. The underlying
bridge is listed there, e.g.:

    openfabric_node: openfab_pve1-cluster
        interfaces name=vmbr12,ip6=fd10:12::2/64
        ip6 fd44::1

So I think the underlying bridge does receive the stanza, but please
correct me if I'm wrong.

You are right that render_dummy_interfaces() also goes through
render_interface(), which is pointless there. I will guard it with
"link_type != Some("dummy")" in the next version.

>> +            writeln!(
>> +                interface,
>> +                "\tpost-down echo 0 > /proc/sys/net/ipv6/conf/{name}/force_forwarding"
>> +            )?;
>> +        }