Re: [PATCH test-tools 1/6] runner: add vmid-range option for test guest VMIDs

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Sep 17, 2026 at 6:23 PM CEST, Michael Köppl wrote:
> +impl FromStr for VmIdRange {
> +    type Err = Error;
> +
> +    fn from_str(s: &str) -> Result<Self, Self::Err> {
> +        let (start, end) = s
> +            .split_once(':')
> +            .ok_or_else(|| format_err!("expected '<start>:<end>', got '{s}'"))?;
> +
> +        let start: u32 = start
> +            .parse()
> +            .with_context(|| format!("invalid range start '{start}'"))?;
> +
> +        let end: u32 = end
> +            .parse()
> +            .with_context(|| format!("invalid range end '{end}'"))?;
> +
> +        if start >= end {
> +            bail!("range start {start} must be lower than its end {end}");
> +        }
> +
> +        if start < VMID_MIN || end > VMID_MAX {
> +            bail!("range must be within {VMID_MIN}..={VMID_MAX}");
> +        }
> +
> +        Ok(Self { start, end })
> +    }
> +}
> +
> +impl std::fmt::Display for VmIdRange {
> +    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
> +        write!(f, "{}:{}", self.start, self.end)
> +    }
> +}
> +
> +impl Serialize for VmIdRange {
> +    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
> +    where
> +        S: serde::Serializer,
> +    {
> +        serializer.collect_str(self)
> +    }
> +}
> +
> +impl<'d> Deserialize<'d> for VmIdRange {
> +    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
> +    where
> +        D: serde::Deserializer<'d>,
> +    {
> +        let s = String::deserialize(deserializer)?;
> +        s.parse().map_err(serde::de::Error::custom)
> +    }
> +}

Btw, you could use:

proxmox_serde::forward_deserialize_to_from_str!(VmIdRange);
proxmox_serde::forward_serialize_to_display!(VmIdRange);

we use these helpers quite often in our code bases already.