public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Jonas Theisen" <j.theisen@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-manager v2 0/2] ui: vm create: populate EFI and
Date: Tue, 29 Sep 2026 15:16:40 +0200	[thread overview]
Message-ID: <DLRTUJ7KEA7H.2397PCTECF2WG@proxmox.com> (raw)
In-Reply-To: <20260806130152.207884-1-j.theisen@proxmox.com>

Gave this a quick try. 

When creating a new VM:
The EFI Storage field is automatically set to the first
item from the list of available locations.

When adding an EFI Disk to an existing VM:
The EFI Storage field is not automatically populated. This matches the
behaviour of other qemu hardware. Consider this:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Thu Aug 6, 2026 at 3:01 PM CEST, Jonas Theisen wrote:
> On VM creation the storage dropdown for EFI and TPM were empty,
> while the storage for VM disks was populated by default.
>
> This patch series adds the parameters to the selectors to also
> populate the storage for EFI and TPM disks automatically and fixes
> an issue where disabling and reenabling the selectors would not
> trigger the autofill.
>
> Reported by a forum user in https://forum.proxmox.com/threads/185473/
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
>
> Jonas Theisen (2):
>   ui: vm create: populate EFI and TPM storage by default
>   ui: vm: create: fix autoSelect for disk storage selector when
>     re-enabling field
>
>  www/manager6/form/DiskStorageSelector.js | 5 +++++
>  www/manager6/qemu/HDEfi.js               | 1 +
>  www/manager6/qemu/HDTPM.js               | 1 +
>  www/manager6/qemu/SystemEdit.js          | 2 ++
>  4 files changed, 9 insertions(+)





      parent reply	other threads:[~2026-09-29 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 13:01 [PATCH pve-manager v2 0/2] ui: vm create: populate EFI and Jonas Theisen
2026-08-06 13:01 ` [PATCH pve-manager v2 1/2] ui: vm create: populate EFI and TPM storage by default Jonas Theisen
2026-08-06 13:01 ` [PATCH pve-manager v2 2/2] ui: vm: create: fix autoSelect for disk storage selector when re-enabling field Jonas Theisen
2026-09-29 13:16 ` Elias Huhsovitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLRTUJ7KEA7H.2397PCTECF2WG@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal