From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-docs 2/2] qm: pci passthrough: fix grammar and spelling
Date: Tue, 25 Aug 2026 14:46:42 +0200 [thread overview]
Message-ID: <DKY1AID4WY9Y.2S7LNUP3VKXR9@proxmox.com> (raw)
In-Reply-To: <20260825114642.278296-3-j.klocker@proxmox.com>
2 nits inline, other than that I like the changes!
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
On Tue Aug 25, 2026 at 1:46 PM CEST, Jakob Klocker wrote:
[snip]
> @@ -300,13 +300,14 @@ VM Configuration
> When passing through a GPU, the best compatibility is reached when using
> 'q35' as machine type, 'OVMF' ('UEFI' for VMs) instead of SeaBIOS and PCIe
> instead of PCI. Note that if you want to use 'OVMF' for GPU passthrough, the
> -GPU needs to have an UEFI capable ROM, otherwise use SeaBIOS instead. To check if
> +GPU needs to have a UEFI-capable ROM, otherwise use SeaBIOS instead. To check if
> the ROM is UEFI capable, see the
> https://pve.proxmox.com/wiki/PCI_Passthrough#How_to_know_if_a_graphics_card_is_UEFI_.28OVMF.29_compatible[PCI Passthrough Examples]
> wiki.
>
> -Furthermore, using OVMF, disabling vga arbitration may be possible, reducing the
> -amount of legacy code needed to be run during boot. To disable vga arbitration:
> +Furthermore, when using OVMF, you may be able to disable VGA arbitration,
nit: might just be me, but to me "you may be able to..." reads like the
the person now has the ability to do so. Maybe something like "VGA
arbitration can potentially be disabled" would be more fitting.
> +which reduces the amount of legacy code that needs to run at boot.
> +To disable VGA arbitration:
>
> ----
> echo "options vfio-pci ids=<vendor-id>,<device-id> disable_vga=1" > /etc/modprobe.d/vfio.conf
> @@ -335,17 +336,17 @@ or by adding a line to the VM configuration file:
[snip]
> +a single device to provide multiple 'VFs' (**V**irtual **F**unctions) to the
> +system. Each of those 'VFs' can be used in a different VM, with full hardware
> +features and also better performance and lower latency than software-virtualized
> +devices.
>
> -Currently, the most common use case for this are NICs (**N**etwork
> +Currently, the most common use case for this is NICs (**N**etwork
nit: both versions read a bit awkward to me, even though the second is
grammatically correct. Maybe something like "Currently, the most common
use case for this is with NICs" could work.
> **I**nterface **C**ard) with SR-IOV support, which can provide multiple VFs per
> -physical port. This allows using features such as checksum offloading, etc. to
> -be used inside a VM, reducing the (host) CPU overhead.
> +physical port. This allows features such as checksum offloading to be used
> +inside a VM, reducing the (host) CPU overhead.
>
> Host Configuration
[snip]
prev parent reply other threads:[~2026-08-25 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 11:46 [PATCH docs 0/2] qm: pci passthrough: various fixes and clarifications Jakob Klocker
2026-08-25 11:46 ` [PATCH pve-docs 1/2] qm: pci passthrough: replace obsolete module loading procedure Jakob Klocker
2026-08-25 13:04 ` Michael Köppl
2026-08-25 11:46 ` [PATCH pve-docs 2/2] qm: pci passthrough: fix grammar and spelling Jakob Klocker
2026-08-25 12:46 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKY1AID4WY9Y.2S7LNUP3VKXR9@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox