From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH common v4 2/3] pem parser: add testsuite for check_ and split_pem
Date: Fri, 14 Aug 2026 16:30:30 +0200 [thread overview]
Message-ID: <DKOQLZW2552U.1E8I3A31R4MVY@proxmox.com> (raw)
In-Reply-To: <20260805141114.190477-3-t.ellmenreich@proxmox.com>
Ran tests using
prove check_pem_test.test
prove split_pem_test.test
Tests seem to cover all important code paths.
Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
On Wed Aug 5, 2026 at 4:11 PM CEST, Thomas Ellmenreich wrote:
> having made considerable changes to both check_pem and split_pem
> in the previous commit, this commit introduces tests for both methods.
>
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
> test/Makefile | 2 +
> test/check_pem_test.pl | 365 +++++++++++++++++++++++++++++++++++++++++
> test/split_pem_test.pl | 279 +++++++++++++++++++++++++++++++
> 3 files changed, 646 insertions(+)
> create mode 100755 test/check_pem_test.pl
> create mode 100755 test/split_pem_test.pl
>
> diff --git a/test/Makefile b/test/Makefile
> index 961a0da..e5a5f42 100644
> --- a/test/Makefile
> +++ b/test/Makefile
> @@ -15,6 +15,8 @@ TESTS = lock_file.test \
> section_config_property_isolation_test.test \
> file-test.test \
> cmd-test.test \
> + check_pem_test.test \
> + split_pem_test.test \
>
> all:
>
> diff --git a/test/check_pem_test.pl b/test/check_pem_test.pl
> new file mode 100755
> index 0000000..b9f11a0
> --- /dev/null
> +++ b/test/check_pem_test.pl
> @@ -0,0 +1,365 @@
> +#!/usr/bin/perl
> +# Tests the PVE::Certificate::check_pem function for
> +# correctness and coverage of edgecases.
> +use strict;
> +use warnings;
> +
> +use lib '../src';
> +
> +use Test::More;
> +
> +use PVE::Certificate;
> +
> +# Arrange
> +my $setup = [
> + {
> + expected_success => 1,
> + name => "full pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
> +AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
> +c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
> +EwJVUzELMAkGA1UECAwCQ0ExEDAOBgNVBAcMB0JlcmtlbGV5MRAwDgYDVQQKDAdU
> +ZXN0IENBMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEv5Q8q1p7qZ2gqkQ0Qn5x
> +0n9yqv8n8n7n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8aNT
> +MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
> +Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
> +SAAwRQIhANfakefakefakefakefakefakefakefakefake
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "other label pem",
> + label => "SOME LABEL",
> + pem => <<'EOF',
> +-----BEGIN SOME LABEL-----
> +MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
> +AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
> +c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
> +EwJVUzELMAkGA1UECAwCQ0ExEDAOBgNVBAcMB0JlcmtlbGV5MRAwDgYDVQQKDAdU
> +ZXN0IENBMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEv5Q8q1p7qZ2gqkQ0Qn5x
> +0n9yqv8n8n7n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8aNT
> +MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
> +Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
> +SAAwRQIhANfakefakefakefakefakefakefakefakefake
> +-----END SOME LABEL-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "simple pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +test
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "spaced out pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +
> +test
> +
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "only newline pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "many newlines pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +
> +
> +
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "no content pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE----------END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "preceding content pem",
> + pem => <<'EOF',
> +some extended content
> +-----BEGIN CERTIFICATE-----
> +test
> +-----END CERTIFICATE-----
> +EOF
> +
> + expected_result => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +test
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "following content pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +test
> +-----END CERTIFICATE-----
> +some extended content
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "empty pem",
> + pem => <<'EOF',
> +
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "upsidedown pem",
> + pem => <<'EOF',
> +-----END CERTIFICATE-----
> +test
> +-----BEGIN CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "multi pem",
> + multiple => 1,
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +12JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +22JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +32JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +42JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "multiple as single pem",
> + pem => <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +Subject: CN=Org Issuing CA 3
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "big pem different label",
> + multiple => 1,
> + label => "LABEL",
> + pem => <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +-----BEGIN LABEL-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END LABEL-----
> +Subject: CN=Org Issuing CA 3
> +Issuer: CN=Org Root CA
> +-----BEGIN LABEL-----
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END LABEL-----
> +Subject: CN=Org Root CA
> +Issuer: CN=Org Root CA
> +-----BEGIN LABEL-----
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END LABEL-----
> +EOF
> +
> + expected_result => <<'EOF',
> +-----BEGIN LABEL-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END LABEL-----
> +-----BEGIN LABEL-----
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END LABEL-----
> +-----BEGIN LABEL-----
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END LABEL-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "other real pem",
> + pem => <<'EOF',
> +Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
> +Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + expected_result => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "invalid single pem",
> + pem => <<'EOF',
> +Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
> +Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdthese !?''*:;$%&/ are not allowedWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 0,
> + name => "invalid multi pem",
> + multiple => 1,
> + pem => <<'EOF',
> +Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
> +Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdthese !?''*:;$%&/ are not allowedWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
> +Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "single as multiple pem",
> + multiple => 1,
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "single as multiple pem",
> + multiple => 1,
> + pem => <<'EOF',
> +Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
> +Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + expected_result => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> +];
> +
> +for my $data ($setup->@*) {
> + subtest $data->{name} => sub {
> + # Act
> + my $check_result = PVE::Certificate::check_pem(
> + $data->{pem},
> + noerr => 1,
> + multiple => $data->{multiple},
> + label => $data->{label},
> + );
> +
> + # Assert
> + if ($data->{expected_success}) {
> + ok($check_result, "is successful");
> +
> + my $expected_result =
> + $data->{expected_result}
> + ? $data->{expected_result}
> + : $data->{pem};
> + is(
> + $check_result, $expected_result, "has correct result content",
> + );
> + } else {
> + is($check_result, undef, "has correctly returned undef");
> + eval {
> + PVE::Certificate::check_pem(
> + $data->{pem},
> + multiple => $data->{multiple},
> + label => $data->{label},
> + );
> + };
> + ok($@, "has correctly thrown an error");
> + }
> + }
> +}
> +
> +done_testing();
> diff --git a/test/split_pem_test.pl b/test/split_pem_test.pl
> new file mode 100755
> index 0000000..4239e5c
> --- /dev/null
> +++ b/test/split_pem_test.pl
> @@ -0,0 +1,279 @@
> +#!/usr/bin/perl
> +# Tests the PVE::Certificate::split_pem function for
> +# correctness and coverage of edgecases.
> +use strict;
> +use warnings;
> +
> +use lib '../src';
> +
> +use Test::More;
> +
> +use PVE::Certificate;
> +
> +# Arrange
> +my $setup = [
> + {
> + expected_success => 1,
> + name => "single pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
> +AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
> +c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
> +EwJVUzELMAkGA1UECAwCQ0ExEDAOBgNVBAcMB0JlcmtlbGV5MRAwDgYDVQQKDAdU
> +ZXN0IENBMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEv5Q8q1p7qZ2gqkQ0Qn5x
> +0n9yqv8n8n7n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8aNT
> +MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
> +Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
> +SAAwRQIhANfakefakefakefakefakefakefakefakefake
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "no extra text pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +12JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +22JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +32JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +42JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + expected_result => [
> + <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +12JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +22JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +32JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +42JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + ],
> + },
> + {
> + expected_success => 1,
> + name => "leading and interleaved text pem",
> + pem => <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +Subject: CN=Org Issuing CA 3
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +Subject: CN=Org Root CA
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + expected_result => [
> + <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +Subject: CN=Org Issuing CA 3
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +Subject: CN=Org Root CA
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + ],
> + },
> + {
> + expected_success => 1,
> + name => "massive glob pem",
> + pem => <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +-----BEGIN CERTIFICATE-----
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +Subject: CN=Org Issuing CA 3
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +Subject: CN=Org Root CA
> +Issuer: CN=Org Root CA
> +-----BEGIN CERTIFICATE-----
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "no beginning pem",
> + pem => <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +Subject: CN=Org Root CA
> +Issuer: CN=Org Root CA
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + expected_result => [
> + <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +Subject: CN=Org Root CA
> +Issuer: CN=Org Root CA
> +3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + ],
> +
> + },
> + {
> + expected_success => 0,
> + name => "not a pem pem",
> + pem => <<'EOF',
> +Subject: CN=some.test.content
> +Issuer: CN=Org Issuing CA 3
> +1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
> +dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
> +dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
> +c2JlZ2tseTxzZWl2IGF3ZWlidm4=
> +Subject: CN=Org Issuing CA 3
> +Issuer: CN=Org Root CA
> +EOF
> + },
> + {
> + expected_success => 1,
> + name => "following text pem",
> + pem => <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +32JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +-----BEGIN CERTIFICATE-----
> +42JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +some more text that we would like to remove
> +EOF
> +
> + expected_result => [
> + <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +32JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> +
> + <<'EOF',
> +-----BEGIN CERTIFICATE-----
> +42JlZ2tseTxzZWl2IGF3ZWlidm4=
> +-----END CERTIFICATE-----
> +EOF
> + ],
> + },
> +];
> +
> +for my $data ($setup->@*) {
> + subtest $data->{name} => sub {
> + # Act
> + my @split_result = PVE::Certificate::split_pem(
> + $data->{pem}, label => $data->{label},
> + );
> +
> + # Assert
> + if ($data->{expected_success}) {
> + ok(@split_result, "is successful");
> + my $expected_result =
> + $data->{expected_result}
> + ? $data->{expected_result}
> + : [$data->{pem}];
> +
> + is_deeply(
> + \@split_result, \@$expected_result, "has correct split output",
> + );
> + } else {
> + is_deeply(\@split_result, [], "has correctly returned empty");
> + }
> + }
> +}
> +
> +done_testing();
next prev parent reply other threads:[~2026-08-14 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 14:11 [PATCH common/proxmox-acme v4 0/3] fix #5978: pem parser: relax parsing of chain entries Thomas Ellmenreich
2026-08-05 14:11 ` [PATCH common v4 1/3] " Thomas Ellmenreich
2026-08-14 14:26 ` Elias Huhsovitz
2026-08-05 14:11 ` [PATCH common v4 2/3] pem parser: add testsuite for check_ and split_pem Thomas Ellmenreich
2026-08-14 14:30 ` Elias Huhsovitz [this message]
2026-08-05 14:11 ` [PATCH common v4 2/3] pem parser: add testsuite for check_pem " Thomas Ellmenreich
2026-08-05 14:23 ` Thomas Ellmenreich
2026-08-05 14:11 ` [PATCH proxmox-acme v4 3/3] fix #5978: pem parser: relax parsing of chain entries: Thomas Ellmenreich
2026-08-14 14:32 ` Elias Huhsovitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKOQLZW2552U.1E8I3A31R4MVY@proxmox.com \
--to=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox