From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Stefan Hanreich" <s.hanreich@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-network 3/3] fix #7738: zones: use pre-computed bridge port list
Date: Tue, 28 Jul 2026 13:58:57 +0200 [thread overview]
Message-ID: <DKA6QP68I4OO.2LC2WDQ29H0XT@proxmox.com> (raw)
In-Reply-To: <20260709132857.239615-4-s.hanreich@proxmox.com>
On 2026-07-09 15:28, Stefan Hanreich <s.hanreich@proxmox.com> wrote:
> The VLAN and QinQ zone utilized ip_link_details to obtain information
> about the physical ports contained on a bridge. Instead of executing
> iproute2 and computing the bridge ports for every VNet, precalculate
> the bridge port list using the new helper in pve-common and then
> re-use the ouput obtained at the start of the run.
>
> Remove the get_bridge_ifaces function, since there are no longer any
> call sites for this function.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Moving the `ip_link_details` call and the corresponding parsing
outside the per-VNet loop makes a lot of sense.
This reduced the reload time reported by the GUI from 12 minutes
to slightly over 1 minute with 1,000 VLAN zones and 1,000 QinQ zones.
Therefore, please consider this:
Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Lukas Sichert <l.sichert@proxmox.com>
prev parent reply other threads:[~2026-07-28 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 13:28 [PATCH common/network 0/3] Performance improvements for applying VLAN / QinQ zones Stefan Hanreich
2026-07-09 13:28 ` [PATCH pve-common 1/3] iproute2: restructure get_physical_bridge_ports Stefan Hanreich
2026-07-27 16:13 ` Lukas Sichert
2026-07-09 13:28 ` [PATCH pve-common 2/3] iproute2: add helper for getting bridge port mappings Stefan Hanreich
2026-07-28 12:00 ` Lukas Sichert
2026-07-09 13:28 ` [PATCH pve-network 3/3] fix #7738: zones: use pre-computed bridge port list Stefan Hanreich
2026-07-28 11:58 ` Lukas Sichert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKA6QP68I4OO.2LC2WDQ29H0XT@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox