From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: superseded: [PATCH proxmox-acme 1/1] fix #7749: always serialize in same order
Date: Mon, 27 Jul 2026 09:33:56 +0200 [thread overview]
Message-ID: <DK96H8VN3MMC.3MRLUUMWAH2GO@proxmox.com> (raw)
In-Reply-To: <DK57OHJS55WH.FKHGDE7ATQ3U@proxmox.com>
Thank you for your review ;)
Superseded-by: https://lore.proxmox.com/pve-devel/20260727072958.37999-1-t.ellmenreich@proxmox.com/T/#u
On Wed Jul 22, 2026 at 5:39 PM CEST, Elias Huhsovitz wrote:
> Small nit below, otherwise
>
> Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
>
[snip]
>
> To guarantee utf8=1, canonical=1. Theoretically %data could contain the
> keys (utf8=0, canonical=0) overriding your manually set values, due to
> perls hash expansion. Re-ordering should guarantee consistency.
I decided to set the new setting manually to make the code more readable.
Otherwise, it would not be clear that this edge case is being addressed by the
code.
[snip]
prev parent reply other threads:[~2026-07-27 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:04 [PATCH proxmox-acme 0/1] fix #7749: always serialize in same order Thomas Ellmenreich
2026-07-14 9:04 ` [PATCH proxmox-acme 1/1] " Thomas Ellmenreich
2026-07-22 15:39 ` Elias Huhsovitz
2026-07-27 7:33 ` Thomas Ellmenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK96H8VN3MMC.3MRLUUMWAH2GO@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox