Re: [PATCH manager v2 1/2] fix #5475: configurable window title

["Thomas Ellmenreich" <t.ellmenreich@proxmox.com>]

Thanks again for your review. I realised I had a question here as well.

[snip]

> 1. The setting names render including the $ symbol, e.g. ($nodename, $fqdn) in the WebUI. 
> This makes it seem broken from an end user point of view. 
> You generally do not expect placeholder values in settings menu.

Rendering the '$' was on purpose, as they are placeholders. Would you
recommend removing just the '$' or would you rather render the actual
values?

I technically copied it from somewhere, as I had a different placeholder
marker, although I can't seem to find that reference anymore.

> 2. I encountered a bug regarding the fdqn setting (see comment below)

I'm investigating that, especially why I didn't have problems with it.
Thanks for noticing.

> 3. I recommend adding some general robustness in case of undef values:
> Initialize $window_title to a safe value not relying on the cluster, in
> case of an error. Expect that the underlying API/calls might return
> undef.

It was an active choice to show something broken in the case of undef, as I
thought hiding the error could also be confusing. But then again, I don't mind
using the fallback value.