Re: [PATCH manager v2] ui: fabrics: skip unsupported interface properties on submit

["Lukas Sichert" <l.sichert@proxmox.com>]

Thanks for looking into this. I will send a v3. Some comments inline:

On 2026-07-14 10:23, Dominik Csapak <d.csapak@proxmox.com> wrote:

> wanted to apply this already, but during testing i noticed
> that even without the patch, we don't have an ipv4 column here, so
> i was confused by the commit message.

You are right, the wording is very misleading here. The base panel
always adds an IPv4 column, but it gets removed with 'me.commonColumns =
me.commonColumns.filter((col) => col.dataIndex !== 'ip');' in
bgp/InterfacePanel.js, so it is not actually there anymore.

I still think it is cleaner to make IPv4 column support configurable,
just like IPv6 column support already is. That part is only a
behavior-preserving cleanup though.

> It turns out, while this patch indeed fixes the error, the rationale
> in the commmit message is not precise and patch seems to conflate two
> things here (correct me if i'm missing something here)
>
> the panel never got a field via the column, because those got
> filtered out via 'hasIpv6Support' or in the initComponent you removed
>
> so the stray 'ip' comes from the overall store, not the columns
> (which get set in 'setValue')
>
> so this patch does two things here:
>
> it moves the removal of the ip column from the initcomponent
> to a config (which is fine IMO, but does not change the actual
> behavior)
>
> and it adds a manual filter in 'getValue' to skip the ip and ip6 field
> depending on this config -> this is what actually fixes the issue
>
>
> i think this should be split into two patch that reflect these two
> changes, with the proper commit messages.
> (though we can do it in one commmit, but then the message must explain
> the issue properly)
>
> the code itself LGTM
>

It absolutely makes sense to do this in two patches. I will split this
into a behavior-preserving cleanup for the IPv4 column handling and a
separate fix for filtering unsupported `ip`/`ip6` properties in
`getValue()` for v3.