Re: [PATCH storage v8 1/5] lvm: saferemove: keep LVs where zero-out failed for manual zero-out

["Michael Köppl" <m.koeppl@proxmox.com>]

On Tue Jul 7, 2026 at 4:32 PM CEST, Lukas Sichert wrote:
[snip]

>  
> @@ -368,18 +365,51 @@ my sub free_lvm_volumes_locked {
>                  errmsg => "can't refresh LV '$lvmpath' to zero-out its data",
>              );
>  
> -            $secure_delete_cmd->($lvmpath);
> +            eval { $secure_delete_cmd->($lvmpath); };
> +            if (my $cleanup_err = $@) {
> +                my $failed_name;
> +                $class->cluster_lock_storage(
> +                    $storeid,
> +                    $scfg->{shared},
> +                    undef,
> +                    sub {
> +                        my $lvs = lvm_list_volumes();

You could pass $vg as a parameter here to limit the lvs command to that
volume group, no?

> +                        my $existing = $lvs->{$vg} // {};
> +
> +                        my $prefix = 'failed-';
> +                        my $suffix = "-del-$name";
> +
> +                        my $last_fail = max(
> +                            0,
> +                            map {
> +                                /^\Q$prefix\E(\d+)\Q$suffix\E$/ ? $1 : ()

[snip]