From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH-SERIES ha-manager 0/2] fix #6084: allow dropping maintenance state with active HA resources
Date: Wed, 08 Jul 2026 16:40:44 +0200 [thread overview]
Message-ID: <DJT9NOARY9Z9.2PO24P8FDREGY@proxmox.com> (raw)
In-Reply-To: <20260708084205.69947-1-d.kral@proxmox.com>
Thanks for these patches!
Tested this in a 3-node cluster by adding a directory storage to node1
only and creating a guest on it, then enabling maintenance mode for
node1, waiting for the migration of the guest to fail, then disabling
maintenance mode again. Without the fix, when checking with `ha-manager
status`, node1's LRM status was still reported as "maintenance". With
the patches applied, the LRM status changed from "maintenance" to
"active" again.
I also had a look at the code. Apart from 1 nit, did not notice anything
and the patches look very solid to me. Nice work!
Consider this:
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
On Wed Jul 8, 2026 at 10:42 AM CEST, Daniel Kral wrote:
> As reported in BZ #6804 [0], if a node held active HA resources, that
> could not be moved to any other node, while a node maintenance request
> has been placed and dropped again, the node's LRM would stay in
> maintenance state even though the maintenance mode was lifted.
>
> This small patch series fixes the issue by also allowing LRMs with
> active assigned HA resources to be moved out of maintenance state again.
[snip]
prev parent reply other threads:[~2026-07-08 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 8:42 [PATCH-SERIES ha-manager 0/2] fix #6084: allow dropping maintenance state with active HA resources Daniel Kral
2026-07-08 8:42 ` [PATCH ha-manager 1/2] test: add maintenance test case with stuck HA resource Daniel Kral
2026-07-08 8:42 ` [PATCH ha-manager 2/2] fix #6084: lrm: allow dropping maintenance with active HA resources Daniel Kral
2026-07-08 14:40 ` Michael Köppl
2026-07-08 14:40 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJT9NOARY9Z9.2PO24P8FDREGY@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox