From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager/qemu-server v2 0/2] fix #5032: sync guest time after restore from saved state
Date: Tue, 23 Jun 2026 16:10:48 +0200 [thread overview]
Message-ID: <DJGHMLBSXTWI.3VYL90ZRJ6R3X@proxmox.com> (raw)
In-Reply-To: <20260622134711.108611-1-j.klocker@proxmox.com>
Tested these patches in combination with proxmox-test-tools.
proxmox-test-instance would regularly run into problems with rollbacks
of entire clusters of test instances when using snapshots with RAM. I
ran automated test runs with rollbacks with RAM in between and checked
that the guest time was the same as on the host for each new test that
was run. Works as expected!
Had a look at the code as well. With the patch mentioned in the cover
letter applied before, the code lgtm as well!
Consider this:
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
On Mon Jun 22, 2026 at 3:47 PM CEST, Jakob Klocker wrote:
> This series adds a new agent option set-time-on-resume to
> automatically synchronize the guest clock via the QEMU Guest Agent
> after operations that can leave the guest time stale. The option is
> enabled by default when the QEMU Guest Agent is configured.
[snip]
prev parent reply other threads:[~2026-06-23 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 13:47 [PATCH manager/qemu-server v2 0/2] fix #5032: sync guest time after restore from saved state Jakob Klocker
2026-06-22 13:47 ` [PATCH qemu-server v2 1/2] fix #5032: qemu: sync guest time on resume and snapshot of " Jakob Klocker
2026-06-22 13:47 ` [PATCH pve-manager v2 2/2] fix #5032: ui: qemu agent: add set-time-on-resume option Jakob Klocker
2026-06-23 14:10 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJGHMLBSXTWI.3VYL90ZRJ6R3X@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox