public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
	<pve-devel@lists.proxmox.com>
Subject: Re: applied: [PATCH docs 0/2] add requirements for HA-managed resources
Date: Tue, 05 May 2026 09:34:12 +0200	[thread overview]
Message-ID: <DIAKI8DNEFGZ.1AW60ZRLWYFOH@proxmox.com> (raw)
In-Reply-To: <177792004458.3134498.13990197696435312088.b4-ty@b4>

On Mon May 4, 2026 at 8:40 PM CEST, Thomas Lamprecht wrote:
> On Mon, 04 May 2026 13:11:53 +0200, Daniel Kral wrote:
>> The first patch cleans up the previous introduction for HA resources a
>> bit and removes some outdated comparison to rgmanager, while the second
>> patch adds a list of requirements with some accompanying text what to do
>> if these requirements are not met.
>> 
>> 
>> Daniel Kral (2):
>>   ha-manager: reword ha resources section
>>   ha-manager: add requirements for ha-managed vms and containers
>> 
>> [...]
>
> Applied, with some wording improvement squashed in, thanks!
>
> Also adapted this slightly to avoid conveying that always all nodes need to
> support all HA resources, as with node affinity that's not a requirement. I
> initially thought about doing that adaption as follow-up, but it was not that
> much change while touching basically quite a few lines due to diff churn, so I
> figured it's better squashed in to keep the commit whole, hope that's OK (I
> did add a notice to the commit message to describe my changes though for
> transparency).

That looks good, the reframing helps in conveying the message that it's
not that these HA resources cannot be added at all, but that admins need
to encode the proper dependencies if they are different from the usual
assumptions. Thanks!

>
> [1/2] ha-manager: reword ha resources section
>       commit: 6e40229424611ea216733259489d605556bb4a32
> [2/2] ha-manager: add requirements for ha-managed vms and containers
>       commit: 8fbf4ab3b38790f6b7219a5e709803ec152055df





      reply	other threads:[~2026-05-05  7:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 11:11 [PATCH docs 0/2] add requirements for HA-managed resources Daniel Kral
2026-05-04 11:11 ` [PATCH docs 1/2] ha-manager: reword ha resources section Daniel Kral
2026-05-04 11:11 ` [PATCH docs 2/2] ha-manager: add requirements for ha-managed vms and containers Daniel Kral
2026-05-04 18:40 ` applied: [PATCH docs 0/2] add requirements for HA-managed resources Thomas Lamprecht
2026-05-05  7:34   ` Daniel Kral [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIAKI8DNEFGZ.1AW60ZRLWYFOH@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal