public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager v2] ui: ha: add disarm/re-arm button
Date: Wed, 15 Apr 2026 09:34:04 +0200	[thread overview]
Message-ID: <DHTJZ8GZQ28Q.209QIE9A1FL3F@proxmox.com> (raw)
In-Reply-To: <20260415064118.33290-1-d.rusovac@proxmox.com>

On Wed Apr 15, 2026 at 8:41 AM CEST, Dominik Rusovac wrote:
> The button to disarm HA in either of the resource modes ('freeze' or
> 'ignore') is disabled as long as HA is disarmed. Analogously, the button
> to arm HA is disabled as long as HA is not disarmed.
>
> The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
> and "Arm HA" are complements. There may be more suitable pairs of icons
> though.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> changes since v1:
> * use camel case for function names
> * choose clearer parameter: 'comp' -> 'menuItem'
> * choose clearer function names:
>   - 'disarm' -> 'handleDisarmButton'
>   - 'rearm'  -> 'handleArmButton'
> * deduplicate translation keys
> * use same translation keys as for menu items
> * remove obsolete 'params'
> * change button text "Re-arm HA" to "Arm HA" 
> * remove extra new-line


Thanks for the swift v2!

Tested in a 3-node cluster and a single node setup and also checked the
error handling with some die's in the API handlers, looks good to me!

Consider this as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>




  reply	other threads:[~2026-04-15  7:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  6:41 Dominik Rusovac
2026-04-15  7:34 ` Daniel Kral [this message]
2026-04-15 12:32 ` Dominik Csapak
2026-04-15 13:32   ` Dominik Rusovac
2026-04-15 14:18     ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHTJZ8GZQ28Q.209QIE9A1FL3F@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal