From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager] ui: ha: add disarm/re-arm button
Date: Tue, 14 Apr 2026 15:49:07 +0200 [thread overview]
Message-ID: <DHSXBUE3JLH3.37Y5HD53O1TTG@proxmox.com> (raw)
In-Reply-To: <DHSWXKSN8XXC.3HHSOBZ41QXXS@proxmox.com>
On Tue Apr 14, 2026 at 3:30 PM CEST, Daniel Kral wrote:
> Nice work, looks great!
>
> I added some inline comments, but functionality-wise this works as
> expected already.
>
thx! will incorporate your suggestions in a v2.
> On Tue Apr 14, 2026 at 1:51 PM CEST, Dominik Rusovac wrote:
>> The button to disarm HA in either of the resource modes ('freeze' or
>> 'ignore') is disabled as long as HA is disarmed. Analogously, the
>> re-arming button is disabled as long as HA is not disarmed.
>>
>> The icons ('unlink' and 'link') are chosen to emphasize that
>> "Disarm HA" and "Re-arm HA" are complements. There may be more
>> suitable pairs of icons though.
>>
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>> www/manager6/ha/Status.js | 106 ++++++++++++++++++++++++++++++++++
>> www/manager6/ha/StatusView.js | 8 +++
>> 2 files changed, 114 insertions(+)
>>
[snip]
next prev parent reply other threads:[~2026-04-14 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 11:51 Dominik Rusovac
2026-04-14 13:30 ` Daniel Kral
2026-04-14 13:49 ` Dominik Rusovac [this message]
2026-04-15 6:44 ` Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHSXBUE3JLH3.37Y5HD53O1TTG@proxmox.com \
--to=d.rusovac@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox