Re: [PATCH proxmox-backup 5/7] manager: add instance-id subcommand

["Lukas Wagner" <l.wagner@proxmox.com>]

On Mon Apr 13, 2026 at 3:26 PM CEST, Shannon Sterz wrote:
> On Mon Apr 13, 2026 at 2:10 PM CEST, Lukas Wagner wrote:
>> For the sake of completeness also allow to query the instance ID from
>> the proxmox-backup-manager admin tool.
>>
>> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
>> ---
>>  src/bin/proxmox_backup_manager/node.rs | 27 ++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/src/bin/proxmox_backup_manager/node.rs b/src/bin/proxmox_backup_manager/node.rs
>> index 4da61690f..34c481587 100644
>> --- a/src/bin/proxmox_backup_manager/node.rs
>> +++ b/src/bin/proxmox_backup_manager/node.rs
>> @@ -32,9 +32,36 @@ fn get_node_config(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<Valu
>>      Ok(Value::Null)
>>  }
>>
>> +#[api(
>> +    input: {
>> +        properties: {
>> +            "output-format": {
>> +                schema: OUTPUT_FORMAT,
>> +                optional: true,
>> +            },
>> +        }
>> +    }
>> +)]
>> +/// Show node configuration
>
> nit: this description should probably also be something like "Get the
> instance ID of the current PBS instance." or similar.
>

Ack! sorry for the copy-paste mistake, I somewhat rushed this so that we
can potentially get this in for the PBS release

>> +fn get_instance_id(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<Value, Error> {
>> +    let output_format = get_output_format(&param);
>> +
>> +    let info = &api2::node::API_METHOD_GET_INSTANCE_ID;
>> +    let mut data = match info.handler {
>> +        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
>> +        _ => unreachable!(),
>> +    };
>> +
>> +    let options = default_table_format_options();
>> +    format_and_print_result_full(&mut data, &info.returns, &output_format, &options);
>> +
>> +    Ok(Value::Null)
>> +}
>> +
>>  pub fn node_commands() -> CommandLineInterface {
>>      let cmd_def = CliCommandMap::new()
>>          .insert("show", CliCommand::new(&API_METHOD_GET_NODE_CONFIG))
>> +        .insert("instance-id", CliCommand::new(&API_METHOD_GET_INSTANCE_ID))
>>          .insert(
>>              "update",
>>              CliCommand::new(&api2::node::config::API_METHOD_UPDATE_NODE_CONFIG)