public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH docs 07/18] ha-manager: crs: remove note about manual changes to datacenter config
Date: Fri, 10 Apr 2026 13:37:07 +0200	[thread overview]
Message-ID: <DHPG0LSUKG0W.1C5Y4C66FJIR6@proxmox.com> (raw)
In-Reply-To: <DHPFMIGA57M1.DK5C55HP0NVA@proxmox.com>

On Fri Apr 10, 2026 at 1:18 PM CEST, Daniel Kral wrote:
> On Fri Apr 10, 2026 at 10:17 AM CEST, Shannon Sterz wrote:
>> On Thu Apr 9, 2026 at 1:41 PM CEST, Daniel Kral wrote:

-->8 snip 8<--

>>> -(`Datacenter` -> `Options`), or directly in `datacenter.cfg`:
>>> -
>>> -----
>>> -crs: ha=static
>>> -----
>>> +(`Datacenter` -> `Options`).
>>>
>>>  [thumbnail="screenshot/gui-datacenter-options-crs.png"]
>>>
>>
>> maybe not super "nice" but we could add the `pvesh` invocation here
>> instead? we seem to do that in other places that lack a dedicated cli
>> (e.g., [1]). so something like:
>>
>> pvesh set /cluster/options --crs "ha=static"
>>
>> [1]: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_add_mapping_for_shared_directories
>
> Thanks for the idea!
>
> Though I'm not entirely sure... I looked for instances where we show how
> to set datacenter config options in the documentation: We also do this
> for the style configuration [0] and for setting the default console [1].
>
> For the latter [1] I think it's alright as it's a single enum value, but
> for the style configuration [0] it might be destructive as it can
> replace the already existing tag-style options as it's a property
> string.
>
> Suggesting people the pvesh command would hide that the 'crs' option is
> a property string and might override other existing options. It would be
> a bit more user-friendly if there's an user interface like `git config`,
> where options can be set individually without interfering with other
> options.
>
> Hope this isn't to pedantic. What do you think?
>
> [0] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_style_configuration
> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_shell_interface_for_the_proxmox_ve_api

i think that's a fair concern. however, admins that use the cli are
likely a bit more proficient anyway. so i think adding the command could
be helpful for users that really want to use the cli.

imo, we might just want to add a warning about how this is a property
string, the consequences of that, and to be careful when using the cli.
but no hard feelings, users familiar with `pvesh` and pve will be able
to figure out this invocation for themselves anyway.

if there are concrete plans for a cli that would improve this (i am not
aware of such efforts), that might be a sensible compromise.







  reply	other threads:[~2026-04-10 11:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 11:41 [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup Daniel Kral
2026-04-09 11:41 ` [PATCH manager 01/18] ui: form/CRSOptions: add missing edit modal title Daniel Kral
2026-04-09 11:41 ` [PATCH manager 02/18] ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode Daniel Kral
2026-04-09 11:41 ` [PATCH manager 03/18] ui: form/CRSOptions: replace HA service term with HA resource Daniel Kral
2026-04-09 11:41 ` [PATCH manager 04/18] ui: form/CRSOptions: use view model for auto rebalancing option Daniel Kral
2026-04-09 11:41 ` [PATCH manager 05/18] ui: form/CRSOptions: allow auto rebalancing only for static and dynamic mode Daniel Kral
2026-04-09 11:41 ` [PATCH docs 06/18] ha-manager: crs: replace service term with HA resource Daniel Kral
2026-04-09 11:41 ` [PATCH docs 07/18] ha-manager: crs: remove note about manual changes to datacenter config Daniel Kral
2026-04-10  8:17   ` Shannon Sterz
2026-04-10 11:18     ` Daniel Kral
2026-04-10 11:37       ` Shannon Sterz [this message]
2026-04-09 11:41 ` [PATCH docs 08/18] ha-manager: crs: improve introduction Daniel Kral
2026-04-09 11:41 ` [PATCH docs 09/18] ha-manager: crs: introduce crs scheduling mode section Daniel Kral
2026-04-09 11:41 ` [PATCH docs 10/18] ha-manager: crs: generalize the description for basic and static load modes Daniel Kral
2026-04-09 11:41 ` [PATCH docs 11/18] ha-manager: crs: remove HA group config from scheduling points list Daniel Kral
2026-04-09 11:41 ` [PATCH docs 12/18] ha-manager: crs: use headings for the scheduling points Daniel Kral
2026-04-09 11:41 ` [PATCH docs 13/18] ha-manager: crs: reword the rebalance on start scheduling point Daniel Kral
2026-04-09 11:41 ` [PATCH docs 14/18] ha-manager: crs: add more information about rebalance on start in its section Daniel Kral
2026-04-09 11:41 ` [PATCH docs 15/18] ha-manager: crs: change crs modes to include all active guests Daniel Kral
2026-04-09 11:41 ` [PATCH docs 16/18] ha-manager: crs: add dynamic load scheduler Daniel Kral
2026-04-09 11:41 ` [PATCH docs 17/18] screenshots: update crs datacenter options screenshot Daniel Kral
2026-04-09 11:41 ` [PATCH docs 18/18] ha-manager: crs: add load balancer section Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHPG0LSUKG0W.1C5Y4C66FJIR6@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal