Re: [PATCH proxmox v2 01/16] notify: smtp: Introduce xoauth2 module

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Mar 25, 2026 at 2:14 PM CET, Arthur Bied-Charreton wrote:
> Prepare proxmox-notify to use the oauth2 crate for SMTP XOAUTH2 support.
>
> The xoauth2 module handles some of the implementation details related to
> supporting XOAUTH2 for SMTP notification targets.
>
> Add get_{google,microsoft}_token functions handling provider-specific
> implementation details, and a ureq::Agent newtype wrapper implementing
> the SyncHttpClient trait to allow using ureq as oauth2 backend, since
> OAuth2 dropped the ureq feature. Debian seems to have patched it out
> due to a ureq 2/3 version mismatch [1].
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  proxmox-notify/Cargo.toml                    |   5 +-
>  proxmox-notify/debian/control                |  27 +--
>  proxmox-notify/src/endpoints/smtp.rs         |   2 +
>  proxmox-notify/src/endpoints/smtp/xoauth2.rs | 167 +++++++++++++++++++
>  4 files changed, 190 insertions(+), 11 deletions(-)
>  create mode 100644 proxmox-notify/src/endpoints/smtp/xoauth2.rs
>
> diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml
> index bc63e19d..421bb6c3 100644
> --- a/proxmox-notify/Cargo.toml
> +++ b/proxmox-notify/Cargo.toml
> @@ -19,6 +19,9 @@ http = { workspace = true, optional = true }
>  lettre = { workspace = true, optional = true }
>  tracing.workspace = true
>  mail-parser = { workspace = true, optional = true }
> +oauth2 = { version = "5.0.0", default-features = false, optional = true }
> +ureq = { version = "3.0.11", features = ["platform-verifier"], optional = true }

Could you make these workspace deps? We also use ureq in proxmox-acme
IIRC, so you should probably then also add a separate commit that
switches that one over to use the version defined in the workspace as
well.


With this fixed in the next version:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>