Re: [PATCH cluster v4 03/28] datacenter config: add auto rebalancing options

["Dominik Rusovac" <d.rusovac@proxmox.com>]

lgtm, consider this

On Thu Apr 2, 2026 at 2:43 PM CEST, Daniel Kral wrote:
> These options control the behavior of the load balancing system in the
> HA Manager.
>
> The imbalance threshold default value is set to `0.3`, as
> experimentation with some common cluster sizes showed good results. This
> might need more adaption in the future, such as a cluster-size-dependent
> profile setting to find a better threshold default value.

+1

>
> Another inbalance threshold default value, which was considered, was
> `0.15`, which is the minimum threshold to detect an imbalance in a
> cluster with one node with load 0.0 and the other nodes with load 1.0
> for a cluster size of up to 45 nodes. For cluster size N, this is
> derived with:
>
>     node_loads = [0.0] + [1.0 for _ in range(N-1)]
>     min_imbalance = calculate_node_imbalance(node_loads)
>
> Though a good starting metric, the imbalance threshold of `0.15` would
> be too sensitive for small cluster sizes and `0.3` was a better balance
> for that.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v3 -> v4:
> - change threshold default value from 0.7 to 0.3
> - add minimum requirements to number fields
>

[snip]

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>