Re: [PATCH v2 proxmox-acme 3/3] buildsys: run tests as part of dpkg-buildpackage

["Kefu Chai" <k.chai@proxmox.com>]

On Wed Apr 1, 2026 at 12:15 AM CST, Thomas Lamprecht wrote:
> Am 31.03.26 um 09:10 schrieb Kefu Chai:
>> Add override_dh_auto_test to debian/rules so that make test is
>> automatically executed during every package build, ensuring the
>> schema and Makefile consistency checks are enforced at build time.
>
> This already happens though? dh_auto_test will already trigger any
> "check" or "test" target if there's a Makefile present, and when
> building a package without your patch here I can see that working.

Yeah, it's already wired into the default dh helper. I ran into 
"No rule to make target 'test'" when running "make test" from the
top-level repo dir, where only the outer Makefile is located. That's 
why I just went ahead and added this in the d/rules in hope to avoid 
the same problem. But I missed the fact that the /Makefile actually 
copies the *src* directory when building debian package. I just found
the same pattern repeats itself in proxmox-biome. Will take a closer
look at the Makefile under root directory next time.

Thanks for pointing this out!

>
> Or am I missing something here?
>
>> 
>> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
>> ---
>>  debian/rules | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/debian/rules b/debian/rules
>> index f00dbc2..2118ffa 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -5,3 +5,6 @@
>>  
>>  %:
>>  	dh $@
>> +
>> +override_dh_auto_test:
>> +	$(MAKE) -C . -f Makefile test