public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] unconfigured: also catch ^C signal with debug shell
Date: Fri, 27 Mar 2026 10:13:48 +0100	[thread overview]
Message-ID: <DHDG792RO2YC.9RRZ4Y7GW6OK@proxmox.com> (raw)
In-Reply-To: <20251219185408.283433-1-c.heiss@proxmox.com>

Ping, still applies.

On Fri Dec 19, 2025 at 7:54 PM CET, Christoph Heiss wrote:
> Currently, pressing Ctrl-C during the installation - mostly relevant
> when running the auto-installer - will cause a kernel panic, as
> unconfigured.sh is running as PID 1.
>
> Instead, drop the user into our debug shell, which is a bit better UX
> and more useful, too.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  unconfigured.sh | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/unconfigured.sh b/unconfigured.sh
> index caa08c3..40e17b0 100755
> --- a/unconfigured.sh
> +++ b/unconfigured.sh
> @@ -3,6 +3,7 @@
>  reboot_action="reboot"
>
>  trap "err_reboot" ERR
> +trap "err_reboot" INT
>
>  # NOTE: we nowadays get exec'd by the initrd's PID 1, so we're the new PID 1
>
> @@ -75,6 +76,9 @@ eject_and_reboot() {
>  real_reboot() {
>      trap - ERR
>
> +    # ignore ^C from this point, we are already shutting down
> +    trap '' INT
> +
>      if [[ -x /etc/init.d/networking ]]; then
>          /etc/init.d/networking stop
>      fi





      reply	other threads:[~2026-03-27  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 18:54 Christoph Heiss
2026-03-27  9:13 ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHDG792RO2YC.9RRZ4Y7GW6OK@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal