public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v2 1/8] serde: implement ini serializer
Date: Wed, 25 Mar 2026 19:02:06 +0100	[thread overview]
Message-ID: <DHC26NJWL7TR.1WJH8JZLE11TC@proxmox.com> (raw)
In-Reply-To: <3a192d9c-eb4d-4a09-9faa-f50c2c24fd9d@proxmox.com>

On Wed Mar 25, 2026 at 1:17 PM CET, Thomas Lamprecht wrote:
> Am 25.03.26 um 12:40 schrieb Christoph Heiss:
>>> Any technical reason for this to be in proxmox-serde over a dedicated
>>> crate? like proxmox-ini or proxmox-ini-config or the like?
>> Not really. Didn't know if we wanted a dedicated crate for this and - as
>> you say below - proxmox-serde is mixed bag of serde-related stuff and
>> it kind of fitted, so just decided to put it there for now.
>>
>> Will move it to a separate crate for v3.
>
> Alternative could be to just put it in proxmox-wireguard directly for now.
> But that mostly depends on how specific this INI flavor is, or how
> different the ones for potential use cases (besides this the usage in
> systemd and git might be the most prominent ones that might interest us
> already or sooner or later).

I think it's worth having it somewhere "public", not specific to
proxmox-wireguard.

The ability to write out multiple sections with the same name should not
interfere with writing any other INI-flavored configuration files (and
apart than that, it is just common INI), so it would be generic enough
to use elsewhere.

If really needed, we could provide a simple toggle for disabling that
support instead of having a whole different serialization
implementation, IMO.




  reply	other threads:[~2026-03-25 18:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 14:35 [PATCH proxmox v2 0/8] sdn: add wireguard fabric configuration support Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 1/8] serde: implement ini serializer Christoph Heiss
2026-03-24 11:13   ` Thomas Lamprecht
2026-03-24 13:08     ` Wolfgang Bumiller
2026-03-25 11:40     ` Christoph Heiss
2026-03-25 12:17       ` Thomas Lamprecht
2026-03-25 18:02         ` Christoph Heiss [this message]
2026-03-24 15:14   ` Wolfgang Bumiller
2026-02-13 14:35 ` [PATCH proxmox v2 2/8] serde: add base64 module for byte arrays Christoph Heiss
2026-03-24 12:57   ` Wolfgang Bumiller
2026-02-13 14:35 ` [PATCH proxmox v2 3/8] network-types: add ServiceEndpoint type as host/port tuple abstraction Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 4/8] schema: provide integer schema for node ports Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 5/8] schema: api-types: add ed25519 base64 encoded key schema Christoph Heiss
2026-02-13 14:35 ` [PATCH proxmox v2 6/8] wireguard: init configuration support crate Christoph Heiss
2026-02-13 14:36 ` [PATCH proxmox v2 7/8] wireguard: implement api for PublicKey Christoph Heiss
2026-02-13 14:36 ` [PATCH proxmox v2 8/8] wireguard: make per-peer preshared key optional Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHC26NJWL7TR.1WJH8JZLE11TC@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal