Re: [PATCH ha-manager v2 3/4] fix #2751: implement disarm-ha and arm-ha for safe cluster maintenance

["Dominik Rusovac" <d.rusovac@proxmox.com>]

two negligible nits inline

On Sun Mar 22, 2026 at 12:42 AM CET, Thomas Lamprecht wrote:

[snip]

> diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
> index 301c391..f6857bd 100644
> --- a/src/PVE/HA/Sim/Hardware.pm
> +++ b/src/PVE/HA/Sim/Hardware.pm
> @@ -835,6 +835,15 @@ sub sim_hardware_cmd {
>                  || $action eq 'disable-node-maintenance'
>              ) {
>                  $self->queue_crm_commands_nolock("$action $node");
> +            } elsif ($action eq 'disarm-ha') {
> +                my $mode = $params[0];
> +
> +                die "sim_hardware_cmd: unknown resource mode '$mode'\n"
> +                    if $mode !~ m/^(freeze|ignore)$/;
> +
> +                $self->queue_crm_commands_nolock("disarm-ha $mode");

    $self->queue_crm_commands_nolock("$action $mode");

nit: following DRY principle, this would be cleaner imo

> +            } elsif ($action eq 'arm-ha') {
> +                $self->queue_crm_commands_nolock("arm-ha");

    $self->queue_crm_commands_nolock("$action");

nit: same here

[snip]