public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Lukas Sichert" <l.sichert@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager 2/2] fix #7339: lvmthick: ui: add UI fields for option to free storage
Date: Mon, 23 Mar 2026 13:39:06 +0100	[thread overview]
Message-ID: <DHA62948FRQQ.1BCPQ3F2D321@proxmox.com> (raw)
In-Reply-To: <20260323101506.56098-3-l.sichert@proxmox.com>

On Mon Mar 23, 2026 at 11:14 AM CET, Lukas Sichert wrote:
> In the previous commit the backend recieved the functionality to discard

this is a bit weird to put in the commit message like that since in the
commit history of pve-manager, there is no related previous commit.

> allocated space of a VM disk on a SAN, when a VM is deleted. The backend
> checks whether to use this option by parsing storage.cfg to see if
> 'issue_blkdiscard' is set to 1. This variable will automatically be
> stored into the config file if it is present in the 'PUT' API request.
> To be able to append this to the API call, the variable needs
> to be defined in the json-Schema, but this has also been added in the
> previous commit.
>
> To enable a option to free storage in the Gui, create a checkbox with
> the name 'issue_blkdiscard'. In the checkbox use cbind to evaluate
> 'iscreate' from the component, to only autoenable on new creations of
> LVM Storages. This checkbox also adds the 'issue_blkdiscard'
> variable and its value to the return call.
>

[snip]




      parent reply	other threads:[~2026-03-23 12:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 10:14 [PATCH manager/storage 0/2] fix #7339: lvmthick: add option to free storage for deleted VMs Lukas Sichert
2026-03-23 10:14 ` [PATCH storage 1/2] fix #7339: lvmthick: add worker to free space of to be " Lukas Sichert
2026-03-23 10:31   ` Michael Köppl
2026-03-23 10:57   ` Maximiliano Sandoval
2026-03-23 12:50   ` Michael Köppl
2026-03-23 10:14 ` [PATCH manager 2/2] fix #7339: lvmthick: ui: add UI fields for option to free storage Lukas Sichert
2026-03-23 10:52   ` Maximiliano Sandoval
2026-03-23 14:01     ` Fabian Grünbichler
2026-03-23 12:39   ` Michael Köppl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHA62948FRQQ.1BCPQ3F2D321@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal