Re: [PATCH ha-manager v2 01/10] rename static node stats to be consistent with similar interfaces

["Daniel Kral" <d.kral@proxmox.com>]

On Thu Mar 19, 2026 at 5:33 PM CET, Daniel Kral wrote:
> diff --git a/src/PVE/HA/Usage/Static.pm b/src/PVE/HA/Usage/Static.pm
> index d586b603..395be871 100644
> --- a/src/PVE/HA/Usage/Static.pm
> +++ b/src/PVE/HA/Usage/Static.pm
> @@ -33,10 +33,10 @@ sub add_node {
>  
>      my $stats = $self->{'node-stats'}->{$nodename}
>          or die "did not get static node usage information for '$nodename'\n";
> -    die "static node usage information for '$nodename' missing cpu count\n" if !$stats->{cpus};
> -    die "static node usage information for '$nodename' missing memory\n" if !$stats->{memory};
> +    die "static node usage information for '$nodename' missing cpu count\n" if !$stats->{maxcpu};
> +    die "static node usage information for '$nodename' missing memory\n" if !$stats->{maxmem};

@Dominik pointed this out to me off-list: even though it's unlikely that
the node max stats will ever be exactly 0, this should be a
!defined($stats->{...}) rather than a !$stats->{...}.

This was existent, so I'd send a follow-up instead of re-sending the
series to minimize noise on the list.

>  
> -    eval { $self->{scheduler}->add_node($nodename, int($stats->{cpus}), int($stats->{memory})); };
> +    eval { $self->{scheduler}->add_node($nodename, int($stats->{maxcpu}), int($stats->{maxmem})); };
>      die "initializing static node usage for '$nodename' failed - $@" if $@;
>  }
>