public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server 2/2] pci: mdev: use PVE::RS::NVML for nvidia mdev information
Date: Thu, 19 Mar 2026 12:23:22 +0100	[thread overview]
Message-ID: <DH6PY37K5Q3O.1GM3PBLJ7KVI5@proxmox.com> (raw)
In-Reply-To: <20260305091711.1221589-12-d.csapak@proxmox.com>

One tiny nit inline (could also be fixed while applying), other than
that please consider it:

Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>

On Thu Mar 5, 2026 at 10:16 AM CET, Dominik Csapak wrote:
> This gets us the missing description that used to be in sysfs.
>
> In case this is an SR-IOV virtual function, we have to get the physical
> device first since only that is a valid device for querying with NVML.
>
> 'pci_dev_physfn_id' is only used here currently so it's a local sub, but
> if we need it in more places, a good place could be 'PVE::SysFSTools' or
> 'PVE::QemuServer::PCI'.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PVE/QemuServer/PCI/Mdev.pm | 45 ++++++++++++++++++++++++----------
>  1 file changed, 32 insertions(+), 13 deletions(-)
>
> diff --git a/src/PVE/QemuServer/PCI/Mdev.pm b/src/PVE/QemuServer/PCI/Mdev.pm
> index 3b42ce2d..51dca474 100644
> --- a/src/PVE/QemuServer/PCI/Mdev.pm
> +++ b/src/PVE/QemuServer/PCI/Mdev.pm
> @@ -2,11 +2,28 @@ package PVE::QemuServer::PCI::Mdev;
>
>  use v5.36;
>
> +use File::Basename;
> +
> +use PVE::RS::NVML;

Nit: Needs the dependency entry on libpve-rs-perl in d/control recorded.




  reply	other threads:[~2026-03-19 11:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  9:16 [PATCH common/debcargo-conf/manager/proxmox-perl-rs/qemu-server 00/13] use NVML for vGPU info querying Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 1/8] nvml-wrapper-sys: Update to 0.9.0 Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 2/8] nvml-wrapper-sys: release 0.9.0-1 Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 3/8] nvml-wrapper: Update to 0.11.0 Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 4/8] nvml-wrapper: release 0.11.0-1 Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 5/8] nvml-wrapper: Update to 0.12.0 Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 6/8] nvml-wrapper: add patch for vgpu ids Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 7/8] backport nvml-wrapper-sys 0.9.0-1 Dominik Csapak
2026-03-05  9:16 ` [PATCH debcargo-conf 8/8] backport nvml-wrapper 0.12.0-1 Dominik Csapak
2026-03-05  9:16 ` [PATCH proxmox-perl-rs 1/1] pve: add binding for accessing vgpu info Dominik Csapak
2026-03-19 11:16   ` Christoph Heiss
2026-03-05  9:16 ` [PATCH qemu-server 1/2] pci: move mdev related code to own module Dominik Csapak
2026-03-05  9:16 ` [PATCH qemu-server 2/2] pci: mdev: use PVE::RS::NVML for nvidia mdev information Dominik Csapak
2026-03-19 11:23   ` Christoph Heiss [this message]
2026-03-05  9:16 ` [PATCH manager 1/1] api: hardware: pci: use NVML for querying " Dominik Csapak
2026-03-05  9:16 ` [PATCH common 1/1] sysfs tools: remove moved code Dominik Csapak
2026-03-10  9:00 ` partially-applied: [PATCH common/debcargo-conf/manager/proxmox-perl-rs/qemu-server 00/13] use NVML for vGPU info querying Fabian Grünbichler
2026-03-19 11:31 ` Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH6PY37K5Q3O.1GM3PBLJ7KVI5@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal