public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: "Roman Ondráček" <mail@romanondracek.cz>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-storage v2 0/1] storage: add xz support
Date: Thu, 19 Mar 2026 11:56:04 +0100	[thread overview]
Message-ID: <DH6PD6NSZS0U.3Q92IH3QXPH3J@proxmox.com> (raw)
In-Reply-To: <20260308175536.612599-1-mail@romanondracek.cz>

On Sun Mar 8, 2026 at 6:55 PM CET, Roman Ondráček wrote:
> A popular ISO compressed exclusively with xz is FreeBSD [1].
>
> Since this requires adding `xz` to the list of known compression
> formats we add decompression methods for vmz and tar.
>
> [1] https://download.freebsd.org/releases/amd64/amd64/ISO-IMAGES/15.0/
>
> Signed-off-by: Roman Ondráček <mail@romanondracek.cz>

Hello again!

Thanks for your patches -- do you mind if I integrate them as part of
another set of changes that I'm currently working on?

Since I'm touching a lot of the surrounding code at the moment, it would
need a lot of rebasing on either of our sides.

You'd obviously still be accredited with adding support for xz in the
form of an Originally-by trailer in the corresponding git commit
messages.

If that's fine with you then no additional work should be needed on
your side -- otherwise I'll give this a more thorough look and see if we
can merge this before any of my changes land.

>
> Roman Ondráček (1):
>   storage: add xz support
>
>  debian/control                     |  1 +
>  src/PVE/Storage.pm                 |  3 +++
>  src/PVE/Storage/Plugin.pm          |  2 +-
>  src/test/archive_info_test.pm      |  6 ++++--
>  src/test/list_volumes_test.pm      | 11 ++++++++++-
>  src/test/parse_volname_test.pm     |  8 ++++----
>  src/test/path_to_volume_id_test.pm | 12 +++++++-----
>  7 files changed, 30 insertions(+), 13 deletions(-)





      parent reply	other threads:[~2026-03-19 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 17:55 Roman Ondráček
2026-03-08 17:55 ` [PATCH pve-storage v2 1/1] " Roman Ondráček
2026-03-19 10:56 ` Max R. Carrara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH6PD6NSZS0U.3Q92IH3QXPH3J@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=mail@romanondracek.cz \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal