Re: [RFC ha-manager 16/21] sim: hardware: add set-dynamic-stats for services

["Dominik Rusovac" <d.rusovac@proxmox.com>]

On Wed Mar 18, 2026 at 11:34 PM CET, Thomas Lamprecht wrote:

[snip] 

> FWIW, we could avoid some code duplication between dynamic and static set
> and reduce the test cmd's needed by applying something like below on top at
> this point.
>
> The change below basically leverage's the rather fresh perl 5.40's "for loop
> with multiple iteration variables" [0] (which is fine to use for PVE 9, we
> won't backport this to PVE 8 - where the perl version would be to old - anyway),
> and merging the two branches for set-static-stats and set-dynamic-stats commands
> by using a hash for mapping the conversions of the different stats/cmds (could
> be written maybe even nicer).
>
> Then such chains like:
>
> info    220      cmdlist: execute service vm:103 set-dynamic-stats cpu 3.9 
> info    220      cmdlist: execute service vm:103 set-dynamic-stats mem 6517
> info    220      cmdlist: execute service vm:104 set-dynamic-stats cpu 6.7 
> info    220      cmdlist: execute service vm:104 set-dynamic-stats mem 8001
> info    220      cmdlist: execute service vm:105 set-dynamic-stats cpu 1.8 
> info    220      cmdlist: execute service vm:105 set-dynamic-stats mem 1201
> info    220      cmdlist: execute service vm:106 set-dynamic-stats cpu 2.1 
> info    220      cmdlist: execute service vm:106 set-dynamic-stats mem 1211
> info    220      cmdlist: execute service vm:107 set-dynamic-stats cpu 0.9 
> info    220      cmdlist: execute service vm:107 set-dynamic-stats mem 1191
>
> could become:
>
> info    220      cmdlist: execute service vm:103 set-dynamic-stats cpu 3.9 mem 6517
> info    220      cmdlist: execute service vm:104 set-dynamic-stats cpu 6.7 mem 8001
> info    220      cmdlist: execute service vm:105 set-dynamic-stats cpu 1.8 mem 1201
> info    220      cmdlist: execute service vm:106 set-dynamic-stats cpu 2.1 mem 1211
> info    220      cmdlist: execute service vm:107 set-dynamic-stats cpu 0.9 mem 1191
>
> I.e., get basically cut in half without really loosing expressiveness (IMO).
>
> [0]: https://perldoc.perl.org/perlexperiment#for-loop-with-multiple-iteration-variables

Good idea, thx, will do!