Re: [RFC proxmox 2/5] resource-scheduling: introduce generic cluster usage implementation

["Daniel Kral" <d.kral@proxmox.com>]

On Mon Mar 9, 2026 at 2:38 PM CET, Dominik Rusovac wrote:
> On Tue Feb 17, 2026 at 3:13 PM CET, Daniel Kral wrote:
>> Declare generic NodeStats and ServiceStats structs, which special use
>> cases convert their types into, and use these to implement generic
>> scheduler methods such as the existing scoring of nodes to start a
>> previously non-running service.
>>
>> This is best viewed with the git option --ignore-all-space.
>>
>> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
>> ---
>
> [snip]
>
>>  /// Scores candidate `nodes` to start a `service` on. Scoring is done according to the static memory
>>  /// and CPU usages of the nodes as if the service would already be running on each.
>>  ///
>>  /// Returns a vector of (nodename, score) pairs. Scores are between 0.0 and 1.0 and a higher score
>>  /// is better.
>> +#[deprecated]
>
> It would be nice to provide a deprecation message, which mentions at
> least the preferred alternative function, via
>
>     #[deprecated = "use ... instead"]
>

Will do so to make the deprecation clearer!

>>  pub fn score_nodes_to_start_service<T: AsRef<StaticNodeUsage>>(
>>      nodes: &[T],
>>      service: &StaticServiceUsage,
>>  ) -> Result<Vec<(String, f64)>, Error> {
>> -    scheduler::score_nodes_to_start_service(nodes, service)
>> +    let nodes = nodes
>> +        .iter()
>> +        .map(|node| node.as_ref().clone().into())
>> +        .collect::<Vec<NodeUsage>>();
>> +
>> +    let cluster_usage = ClusterUsage::from_nodes(nodes);
>> +
>> +    cluster_usage.score_nodes_to_start_service(*service)
>>  }