public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Kefu Chai" <k.chai@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
	"Kefu Chai" <k.chai@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager v1] add default pgettext/npgettext implementations to index.html.tpl
Date: Tue, 10 Mar 2026 17:18:26 +0800	[thread overview]
Message-ID: <DGYZNJ0IX4FF.C2QEIYXNRVX5@proxmox.com> (raw)
In-Reply-To: <20260228060333.3268576-2-k.chai@proxmox.com>

Hi Thomas,

Could help review this change as well? It's similar to the other changes
adding default implementations for the gettext() variant functions.
Without these changes, we would not be able to introduce them to the 
proxmox-i18n project.

cheers,

On Sat Feb 28, 2026 at 2:03 PM CST, Kefu Chai wrote:
> This adds default implementations for pgettext() and npgettext() functions
> to prevent UI breakage when no language is selected.
>
> These functions are required for context-aware translations support added
> to the proxmox-i18n tooling.
>
> Default implementations:
> - pgettext(context, message): Returns message (ignores context)
> - npgettext(context, singular, plural, count): Returns appropriate form
>
> When a language file is loaded, these defaults are replaced by the actual
> translation functions from the i18n catalog.
>
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
> ---
>  www/index.html.tpl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/www/index.html.tpl b/www/index.html.tpl
> index 0c289bbe..74ee02d9 100644
> --- a/www/index.html.tpl
> +++ b/www/index.html.tpl
> @@ -27,6 +27,8 @@
>      <script type='text/javascript'>
>          function gettext(message) { return message; }
>          function ngettext(singular, plural, count) { return count === 1 ? singular : plural; }
> +        function pgettext(context, message) { return message; }
> +        function npgettext(context, singular, plural, count) { return count === 1 ? singular : plural; }
>      </script>
>      [% END %]
>      [%- IF debug %]





      reply	other threads:[~2026-03-10  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  6:03 Kefu Chai
2026-03-10  9:18 ` Kefu Chai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGYZNJ0IX4FF.C2QEIYXNRVX5@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal