From: "Kefu Chai" <k.chai@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Kefu Chai" <k.chai@proxmox.com>, <pve-devel@lists.proxmox.com>
Cc: Kefu Chai <tchaikov@gmail.com>
Subject: Re: [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals
Date: Tue, 10 Mar 2026 15:52:14 +0800 [thread overview]
Message-ID: <DGYXTJ147GXG.XOLELV99SB24@proxmox.com> (raw)
In-Reply-To: <20260228061320.3279182-1-k.chai@proxmox.com>
Hi Thomas,
Could you please help review this change? It would help us to add the
context-aware support to our gettext-based i18n.
cheers,
On Sat Feb 28, 2026 at 2:13 PM CST, Kefu Chai wrote:
> From: Kefu Chai <tchaikov@gmail.com>
>
> These context-aware gettext functions are now being used in
> proxmox-i18n projects and need to be recognized as valid
> global functions by biome to prevent undefined variable
> errors during 'make deb'.
>
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
> ---
> src/biome.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/biome.json b/src/biome.json
> index cda44243..ea8709be 100644
> --- a/src/biome.json
> +++ b/src/biome.json
> @@ -128,7 +128,9 @@
> "Proxmox",
> "eslint",
> "ngettext",
> - "gettext"
> + "gettext",
> + "pgettext",
> + "npgettext"
> ]
> }
> }
next prev parent reply other threads:[~2026-03-10 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 6:13 Kefu Chai
2026-03-10 7:52 ` Kefu Chai [this message]
2026-03-10 9:09 ` applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGYXTJ147GXG.XOLELV99SB24@proxmox.com \
--to=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=tchaikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox