Re: [PATCH ha-manager] resources: Expand max_restart option

["Daniel Kral" <d.kral@proxmox.com>]

On Mon Mar 2, 2026 at 1:28 PM CET, Maximiliano Sandoval wrote:
> When read next to `max_relocate` it is not clear which happens first
> after a service fails to start.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> When writting I initially had "When reached, the service will be attempted to be
> relocated" since it was clear it had to be on a "node" but as per HA rules not
> all of them might be eligible or some of them might already have reached the
> max_restart limit.

Looks good to me! Consider this as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>

>
>  src/PVE/HA/Resources.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
> index 68d9d16..66dd7b4 100644
> --- a/src/PVE/HA/Resources.pm
> +++ b/src/PVE/HA/Resources.pm
> @@ -73,7 +73,8 @@ EODESC
>          },
>          max_restart => {
>              description => "Maximal number of tries to restart the service on"
> -                . " a node after its start failed.",
> +                . " a node after its start failed. When reached, the service will be attempted to"
> +                . " be relocated on an eligible node.",
>              type => 'integer',
>              optional => 1,
>              default => 1,