Re: [PATCH-SERIES qemu-server/guest-common/container v2 00/14] migration: strict config check for intra-cluster migration

["Daniel Kral" <d.kral@proxmox.com>]

On Wed Feb 25, 2026 at 4:18 PM CET, Fiona Ebner wrote:
> Changes in v2:
> * add patches for container
> * log when skipping strict configuration check
>
> For remote migration, we already check that the config can be parsed
> on the target. Do the same for intra-cluster migration, to avoid
> issues like [0] for future new settings, with settings being
> unexpectedly ignored on the target, and in the case of qemu-server
> even relatively silently dropped (there are warnings in the target's
> system logs). In case of containers, an example is migrating a
> container with a mountpoint with 'keepattrs' to a node with a too old
> pve-container version, resulting in the mountpoint not being mounted
> on the target.

Gave this test series a spin in a 3-node cluster with two nodes upgraded
to the patches applied (where one node has the additional shiny-new
property for the VM and container $confdesc) and the third node doesn't
have the patches applied.

For both VMs and containers:
 - offline and online migration succeeds from node with extra prop to
   node without patches applied (skip as expected)
 - offline and online migration fails to node from with extra prop to
   node with patches applied but no extra prop (expected)
 - same if second patched node has another additional property unequal
   to the one on the other patched node (expected)
 - appending --force skipped the strict config check (expected)
 - offline and online migration succeeds between nodes with patches
   applied where the guest doesn't have any additional props (expected)

One thing I noticed is that the new prop is dropped from the config to a
node that doesn't support the strict config check yet for VMs, but for
containers it still stays in the config. Good to check this already as
that may change in the future.

Besides the three inline nodes in patch #6, the changes look good to me
and testing some intra-cluster migrations worked as expected.

With the points in #6 resolved, consider the patch series as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>