public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox] resource-scheduling: topsis: add context to 'unwraps'
Date: Thu, 26 Feb 2026 10:28:53 +0100	[thread overview]
Message-ID: <DGOSCZVD6JNC.2WLLI4O3E1DL7@proxmox.com> (raw)
In-Reply-To: <DGO4Y6RHPGRU.3NC0XBPGR8Q4W@proxmox.com>

I agree, unwrapping the option is indeed questionable. Yet these unwraps
seemed good enough and I didn't want to touch the error handling itself,
as it would entail more changes. Atm, we have no designated Error types
to map to and imo just bail!-ing on a Result in this place adds no
reasonable value. Consistently propagating errors from start to end
would be more appropriate, I suppose.

For now, I just added some context as to what must have gone wrong in
this very situation, because it changes just a tiny bit of code, while
adding reasonable information. 

I could send a v2 that touches error handling in general, though.




  reply	other threads:[~2026-02-26  9:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 13:06 Dominik Rusovac
2026-02-25 15:08 ` Daniel Kral
2026-02-26  9:28   ` Dominik Rusovac [this message]
2026-02-26 10:18     ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGOSCZVD6JNC.2WLLI4O3E1DL7@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal