public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Markus Frank" <m.frank@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH guest-common v2 1/11] mapping: dir: add 'live-migration-method' parameter
Date: Wed, 25 Feb 2026 11:42:24 +0100	[thread overview]
Message-ID: <DGNZAQFN8X2P.3G4V2KO36L5CW@proxmox.com> (raw)
In-Reply-To: <20260223155951.468572-2-m.frank@proxmox.com>

On Mon Feb 23, 2026 at 4:39 PM CET, Markus Frank wrote:
> If a live migration method is selected, qemu-server starts virtiofsd
> with the flags to enable live migration using the chosen method.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
>  src/PVE/Mapping/Dir.pm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/src/PVE/Mapping/Dir.pm b/src/PVE/Mapping/Dir.pm
> index 5ff02d1..a7d4c05 100644
> --- a/src/PVE/Mapping/Dir.pm
> +++ b/src/PVE/Mapping/Dir.pm
> @@ -74,6 +74,15 @@ my $defaultData = {
>              description => "The ID of the directory mapping",
>              format => 'pve-configid',
>          },
> +        'live-migration-method' => {
> +            description => "Allow live-migration when using the directory with a virtiofs device."
> +                ." Ensure you are using the same shared directory on all hosts."
> +                ." Available migration methods are 'file-handles' and 'find-path'.",
> +            type => 'string',
> +            optional => 1,
> +            default => 'file-handles',

The default is off here, as an unset 'live-migration-method' disables
the live migration for VMs that use that virtiofsd mapping.

This should either be clarified as-is in the {verbose_,}description or a
third enum such as 'none' could be introduced to expose that state
explicitly.

> +            enum => ['file-handles', 'find-paths'],
> +        },
>          description => {
>              type => 'string',
>              description => "Description of the directory mapping",
> @@ -99,6 +108,7 @@ sub private {
>  sub options {
>      return {
>          description => { optional => 1 },
> +        'live-migration-method' => { optional => 1 },
>          map => {},
>      };
>  }





  reply	other threads:[~2026-02-25 10:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 15:39 [PATCH guest-common/qemu-server/docs/manager v2 0/11] Virtiofs improvements Markus Frank
2026-02-23 15:39 ` [PATCH guest-common v2 1/11] mapping: dir: add 'live-migration-method' parameter Markus Frank
2026-02-25 10:42   ` Daniel Kral [this message]
2026-02-23 15:39 ` [PATCH qemu-server v2 2/11] fix #6370: virtiofs: add support for thread-pool-size option Markus Frank
2026-02-25 10:46   ` Daniel Kral
2026-02-23 15:40 ` [PATCH qemu-server v2 3/11] virtiofs: add readonly option Markus Frank
2026-02-23 15:40 ` [PATCH qemu-server v2 4/11] virtiofs: add live migration support Markus Frank
2026-02-25 10:45   ` Daniel Kral
2026-02-23 15:40 ` [PATCH docs v2 5/11] virtiofs: add explanation for cache=metadata behavior Markus Frank
2026-02-23 15:40 ` [PATCH docs v2 6/11] virtiofs: add table for optional parameters Markus Frank
2026-02-23 15:40 ` [PATCH docs v2 7/11] virtiofs: add thread-pool-size description Markus Frank
2026-02-25 10:46   ` Daniel Kral
2026-02-23 15:40 ` [PATCH docs v2 8/11] virtiofs: add documentation for live migration Markus Frank
2026-02-23 15:40 ` [PATCH manager v2 09/11] fix #6370: ui: virtiofs edit: add support for thread-pool-size option Markus Frank
2026-02-25 10:46   ` Daniel Kral
2026-02-23 15:40 ` [PATCH manager v2 10/11] virtiofs edit: add support for readonly option Markus Frank
2026-02-23 15:40 ` [PATCH manager v2 11/11] directory mapping: add live-migration-method option for virtiofs Markus Frank
2026-02-25 10:46   ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGNZAQFN8X2P.3G4V2KO36L5CW@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal