Re: [pve-devel] [PATCH ceph 4/4 v5] make: build with pkg.ceph.crimson build profile

["Kefu Chai" <k.chai@proxmox.com>]

On Fri Jan 23, 2026 at 9:03 PM CST, Fabian Grünbichler wrote:
> On January 23, 2026 8:56 am, Kefu Chai wrote:
>> Enable the pkg.ceph.crimson build profile to build Crimson OSD packages.
>> While the previous commit added patches for Crimson support, the build
>> profile must be explicitly activated to generate the ceph-osd-crimson
>> package.
>> 
>> Additionally, add ceph-osd-classic and ceph-osd-crimson to DEBS_REST
>> and DBG_DEBS so they are included in the default "all" Makefile target.
>
> works for now - I do wonder whether it wouldn't make sense to flip this
> at some point upstream and introduce a *pkg.ceph.nocrimson* profile
> instead, that when set, disables all the crimson-specific bits..
>

Good point! Actually, I'd prefer removing it once the upstream is able to 
ditch the support to Ubuntu Jammy.

> but maybe it is still too early for that now :)
>
>> 
>> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
>> ---
>>  Makefile | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Makefile b/Makefile
>> index 3e9749bd65f..671d84a9419 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -17,6 +17,8 @@ ceph-mds-dbg_${PKGVER}_${ARCH}.deb \
>>  ceph-mgr-dbg_${PKGVER}_${ARCH}.deb \
>>  ceph-mon-dbg_${PKGVER}_${ARCH}.deb \
>>  ceph-osd-dbg_${PKGVER}_${ARCH}.deb \
>> +ceph-osd-classic-dbg_${PKGVER}_${ARCH}.deb \
>> +ceph-osd-crimson-dbg_${PKGVER}_${ARCH}.deb \
>>  ceph-test-dbg_${PKGVER}_${ARCH}.deb \
>>  libcephfs2-dbg_${PKGVER}_${ARCH}.deb \
>>  librados2-dbg_${PKGVER}_${ARCH}.deb \
>> @@ -36,6 +38,8 @@ ceph-mds_${PKGVER}_${ARCH}.deb \
>>  ceph-mgr_${PKGVER}_${ARCH}.deb \
>>  ceph-mon_${PKGVER}_${ARCH}.deb \
>>  ceph-osd_${PKGVER}_${ARCH}.deb \
>> +ceph-osd-classic_${PKGVER}_${ARCH}.deb \
>> +ceph-osd-crimson_${PKGVER}_${ARCH}.deb \
>>  ceph-resource-agents_${PKGVER}_${ARCH}.deb \
>>  ceph-test_${PKGVER}_${ARCH}.deb \
>>  libcephfs2_${PKGVER}_${ARCH}.deb \
>> @@ -90,7 +94,7 @@ ${BUILDSRC}: ${SRCDIR} patches
>>  deb: ${DEBS} ${DBG_DEBS}
>>  ${DEBS_REST} ${DBG_DEBS}: $(MAIN_DEB)
>>  $(MAIN_DEB): ${BUILDSRC}
>> -	cd ${BUILDSRC}; dpkg-buildpackage -b -uc -us
>> +	cd ${BUILDSRC}; dpkg-buildpackage -b -uc -us -Ppkg.ceph.crimson
>>  	lintian ${DEBS}
>>  	@echo ${DEBS}
>>  
>> -- 
>> 2.47.3
>> 
>> 
>> 
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>> 
>> 
>> 
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel