public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
	"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH common 4/4] sysfs: use new PVE::RS::VFIO::Nvidia module to retrieve vGPU info
Date: Wed, 21 Jan 2026 14:06:20 +0100	[thread overview]
Message-ID: <DFUAFVLTE3II.2VVTB33Q45OVN@proxmox.com> (raw)
In-Reply-To: <f4d4fd90-003c-40c7-8320-29ec9d149395@proxmox.com>

On Wed Jan 21, 2026 at 9:08 AM CET, Dominik Csapak wrote:
> On 1/20/26 4:00 PM, Thomas Lamprecht wrote:
>> Am 20.01.26 um 14:12 schrieb Christoph Heiss:
[..]
>>> +use PVE::RS::VFIO::Nvidia;
>>
>> we do not depend on libpve-rs-perl in libpve-common-perl, and if easily possible
>> I'd strongly favor keeping it that way,

Yeah, I'm not happy with that either - was also going to say (seems my
patch notes got lost somewhere) that using PVE::RS::VFIO means
get_mdev_types() doesn't only deal with sysfs stuff anymore - so might
make sense to move the mdev stuff anyway.

>> bootstrapping and handling bigger package
>> bumps with newer versioned dependencies or break/depends bumps is already quite
>> a bit of work as is, such stuff does not make it easier, especially if adding
>> a new dependencies is not recorded in d/control's packaging definition.

Right, I knew I forgot something - sorry.

>>
>> Can this move to some non-leaf package instead? Where are the users of this, only
>> qemu-server or other too (pve-manager?)?
[..]
>
> In summary I think simply moving the mdev/vgpu stuff to qemu-server
> makes the most sense for now.

A separate package for vfio/mdev/vgpu type stuff could make sense, as
that code will probably grow some more.
OTOH, if (most) new stuff is implemented through
proxmox-ve-rs/proxmox-perl-rs in the future, having it live in
qemu-server definitely makes a lot of sense too, I think.

I'm open to suggestions in any case, happy to rework that as needed.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2026-01-21 13:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 13:13 [pve-devel] [PATCH proxmox-{ve, perl}-rs/common 0/4] use native libnvidia-ml library for " Christoph Heiss
2026-01-20 13:13 ` [pve-devel] [PATCH proxmox-ve-rs 1/4] vfio: add crate for interacting with vfio host devices Christoph Heiss
2026-01-20 13:13 ` [pve-devel] [PATCH proxmox-ve-rs 2/4] vfio: add rust-native interface for accessing NVIDIA vGPU info Christoph Heiss
2026-01-20 13:13 ` [pve-devel] [PATCH proxmox-perl-rs 3/4] pve: add bindings for proxmox-ve-vfio Christoph Heiss
2026-01-20 13:13 ` [pve-devel] [PATCH common 4/4] sysfs: use new PVE::RS::VFIO::Nvidia module to retrieve vGPU info Christoph Heiss
2026-01-20 15:00   ` Thomas Lamprecht
2026-01-21  8:08     ` Dominik Csapak
2026-01-21 13:06       ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFUAFVLTE3II.2VVTB33Q45OVN@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal